Feat: Adding scheduled query to Bigquery modules#454
Open
jessikad-google wants to merge 12 commits intomainfrom
Open
Feat: Adding scheduled query to Bigquery modules#454jessikad-google wants to merge 12 commits intomainfrom
jessikad-google wants to merge 12 commits intomainfrom
Conversation
jessikad-google
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bradegler
requested changes
Jan 26, 2026
| params = { | ||
| destination_table_name_template = "test_table_schedule" | ||
| write_disposition = "WRITE_APPEND" | ||
| query = "SELECT * FROM `github_metrics.events` WHERE created_at >= TIMESTAMP_SUB(@run_time, INTERVAL 24 HOUR)" |
Contributor
There was a problem hiding this comment.
Its probably safer to say create_at >= (select max(created_at) from test_table_schedule). Its less efficient more is also not going to lose data if it fails to run for more than a day.
| member = each.value | ||
| } | ||
|
|
||
| module "scheduled_queries" { |
Contributor
There was a problem hiding this comment.
I would move this module up one level. That will make it easier to just copy it into staging/prod. We don't use this BQ module there.
We should add "combining OSS GMA terraform with 1P terraform" to the back log.
| type = list(any) | ||
| default = [ | ||
| { | ||
| name = "test_table_schedule" |
Contributor
There was a problem hiding this comment.
We'll want this table definition in tf eventually too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a scheduled query terraform module for future usage.