Mistake in JS version prevents it from running#95
Open
MDjavaheri wants to merge 1 commit intoabbyy:masterfrom
Open
Mistake in JS version prevents it from running#95MDjavaheri wants to merge 1 commit intoabbyy:masterfrom
MDjavaheri wants to merge 1 commit intoabbyy:masterfrom
Conversation
|
i think you are wrong. the '==' is fine. they wanna make sure you are not using the default value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small fix
There's a simple typo in the JS sample code that's preventing this from running. A
==should be!=.Before:
After: