Search Field for checkbox-treeviewer in Object Selection WizardPage#305
Search Field for checkbox-treeviewer in Object Selection WizardPage#305aarnapant-sap wants to merge 3 commits into
Conversation
| private boolean matchesSearch(IOverwriteObject obj) { | ||
| if (this.searchText.isEmpty()) { | ||
| return true; | ||
| } | ||
|
|
||
| String name = obj.getName() != null ? obj.getName().toLowerCase() : ""; | ||
|
|
||
| return name.contains(this.searchText); | ||
| } |
There was a problem hiding this comment.
We are only checking for name match here. But we should provide the filtering for all properties for which we have columns.
This should also include the name of the repository.
There was a problem hiding this comment.
now search happen for name, package and type as well
There was a problem hiding this comment.
Shall we also have it for the action?
For example, users can deselect all objects that are marked for deletion.
There was a problem hiding this comment.
Maybe for actions we can have a drop down/ enum based filter rather than text filter because like if I have a class that have "added" string in its objName but its actually modified then we would also have to show those which might cause confusion.
| AbapGitDialogPageObjLog_push_title=ABAP objects export log | ||
| AbapGitWizardPageBranchAndPackage_title=Branch and Package Selection | ||
| AbapGitWizardPageObjectsSelectionForPull_Title=Object Selection for Pull | ||
| AbapGitWizardPageObjectsSelectionForPull_SearchField_Message=Type filter text |
There was a problem hiding this comment.
Change Type to lowercase. This is just to make it consistent with the views.
| private boolean matchesSearch(IOverwriteObject obj) { | ||
| if (this.searchText.isEmpty()) { | ||
| return true; | ||
| } | ||
|
|
||
| String name = obj.getName() != null ? obj.getName().toLowerCase() : ""; | ||
|
|
||
| return name.contains(this.searchText); | ||
| } |
There was a problem hiding this comment.
Shall we also have it for the action?
For example, users can deselect all objects that are marked for deletion.
| public static String AbapGitWizardPageBranchAndPackage_title; | ||
| public static String AbapGitWizardPageFolderLogic_title; | ||
| public static String AbapGitWizardPageObjectsSelectionForPull_Title; | ||
| public static String AbapGitWizardPageObjectsSelectionForPull_SearchField_Placeholder; |
There was a problem hiding this comment.
Align the name, same as the one in properties file.
2 participants
Added search functionality to the AbapGitWizardPageObjectsSelectionForPull wizard page, enabling users to efficiently search through all modified objects across repositories without UI freezing.