Skip to content

Security Fix for RCE on "wireless-tools" - huntr.dev #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntr-helper wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Security Fix for RCE on "wireless-tools" - huntr.dev #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf2310
fixed rce
Asjidkalam Sep 9, 2020
51ef329
Merge pull request #2 from Asjidkalam/master
JamieSlome Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions ifconfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var child_process = require('child_process');
*
*/
var ifconfig = module.exports = {
exec: child_process.exec,
exec: child_process.execFile,
status: status,
down: down,
up: up
Expand Down Expand Up @@ -188,11 +188,16 @@ function parse_status_interface(callback) {
*
*/
function status(interface, callback) {
var cmd = "";
if (callback) {
this.exec('ifconfig ' + interface, parse_status_interface(callback));
cmd = 'ifconfig ' + interface;
cmd = cmd.split(' ');
this.exec(cmd[0], cmd.slice(1), parse_status_interface(callback));
}
else {
this.exec('ifconfig -a', parse_status(interface));
cmd = 'ifconfig -a';
cmd = cmd.split(' ');
this.exec(cmd[0], cmd.slice(1), parse_status(interface));
}
}

Expand All @@ -214,7 +219,9 @@ function status(interface, callback) {
*
*/
function down(interface, callback) {
return this.exec('ifconfig ' + interface + ' down', callback);
var cmd = 'ifconfig ' + interface + ' down';
cmd = cmd.split(' ');
return this.exec(cmd[0], cmd.slice(1), callback);
}

/**
Expand All @@ -241,9 +248,11 @@ function down(interface, callback) {
*
*/
function up(options, callback) {
return this.exec('ifconfig ' + options.interface +
' ' + options.ipv4_address +
' netmask ' + options.ipv4_subnet_mask +
' broadcast ' + options.ipv4_broadcast +
' up', callback);
var cmd = 'ifconfig ' + options.interface +
' ' + options.ipv4_address +
' netmask ' + options.ipv4_subnet_mask +
' broadcast ' + options.ipv4_broadcast +
' up', callback;
cmd = cmd.split(' ');
return this.exec(cmd[0], cmd.slice(1));
}