Skip to content

Update MAINTAINERS.md#289

Closed
Apollon77 wants to merge 3 commits intoabandonware:masterfrom
Apollon77:patch-1
Closed

Update MAINTAINERS.md#289
Apollon77 wants to merge 3 commits intoabandonware:masterfrom
Apollon77:patch-1

Conversation

@Apollon77
Copy link
Copy Markdown

@Apollon77 Apollon77 commented Jan 3, 2023

I certify that I will work on this project to satisfy community interest and not intend to do any malicious changes.

Some references of my OSS contributions and profiles:

@rzr
Copy link
Copy Markdown

rzr commented Jan 4, 2023

Please drop my name I file, I'll add it later when you're the maintainer :)

Please update commit message to align the template

#10

Also are you into any web of trust ? Do you use GPG ?
Are you also member of any org that use a trust policy ?

@Apollon77
Copy link
Copy Markdown
Author

Done, and "no" to your questions

@rzr
Copy link
Copy Markdown

rzr commented Jan 4, 2023

ok where are you based ? do you know about pgp signing parties ?

https://www.debian.org/events/keysigning

@Apollon77
Copy link
Copy Markdown
Author

I'm located in germany and yes somewhen back in time I had a gpg key for an older email with the reality that noone cared and so I never updated it - and I also never really missed it after that. So yes I know but for now I still have no real need for it

@rzr
Copy link
Copy Markdown

rzr commented Jan 4, 2023

well I am trying to establish a flow for @abandonware/maintainers so I was inspired by debian policy which looks to work well over time... may I suggest to get refresh or create new key and get it signed by established trustworthy orgs, I am mentioning debian but there should be others I let you investigate :)

@Apollon77
Copy link
Copy Markdown
Author

Apollon77 commented Jan 4, 2023

is it a suggestion or a requirement for being a maintainer?

@rzr
Copy link
Copy Markdown

rzr commented Jan 4, 2023

Well I committed to provide trustworthy maintainership for community
today it's a requirement but @abandonware/maintainers may be open to new suggestions

@Apollon77
Copy link
Copy Markdown
Author

I basically understand your idea but also must say that this is complete overkill from all my experience in the GitHub open source world and community (when you exclude kernel and OS development maybe). But all the Node.js world is not using any of that and I would not know a single project where you need a PGP key - even not Node.js itself.

Trust is controlled by reviews and yes commitment and security against hacking attacks is 2FA in the today's world. Trust is shown by contributions and stars and such stuff.

I'm very honest: Some of my projects in the smart home world rely on noble and so I try to support because in the end we have the same goal. The alternative is to fork myself again and continue with an own scoped package, but I do not want to do this because it makes more sense to only have one project and I want to contribute to the community.

If this, together with the fact that I'm one of the core developers of a smart home system (iobroker) with more then 70k installations and access to all the core projects of that and also maintainer of several highly used libraries where also node-red-plugins and homebrigde-plugins base on, is not enough for you, then I will step back and will close this maintainer PR. Then I just support by doing PRs, all fine. I have too many other projects where I can use my rare time to really bring a difference and I do not have the time for formalisms like this ...

@rzr
Copy link
Copy Markdown

rzr commented Jan 4, 2023

Your points are valid, any opinion from other @abandonware members ?

@rzr
Copy link
Copy Markdown

rzr commented Jan 5, 2023

ping @abandonware/reviewers

@Apollon77
Copy link
Copy Markdown
Author

Soooo ... 5 months later ;-) I now also start on bleno to look into things ... sooooo.... any update how to continue here?

@rzr
Copy link
Copy Markdown

rzr commented Jun 17, 2023

Well It looks like nobody objected, so we're in good progress.

Maybe we can have a short talk with @abandonware/reviewers @abandonware/owners @abandonware/maintainers @abandonware if you want ?

Reach me at:

https://matrix.to/#/@rzr:matrix.org

@Apollon77
Copy link
Copy Markdown
Author

Done.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 18, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.79%. Comparing base (b5981f5) to head (438abb4).
⚠️ Report is 29 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   91.87%   91.79%   -0.08%     
==========================================
  Files          25       24       -1     
  Lines        2929     2902      -27     
==========================================
- Hits         2691     2664      -27     
  Misses        238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@donavanbecker
Copy link
Copy Markdown

@rzr any update on this?

@rzr
Copy link
Copy Markdown

rzr commented Feb 6, 2024

Well I still wish the applicant to be part of an existing community... meanwhile I can do the maintenance , I'll revise my mind when missing in action

Relate-to: abandonware/abandonware.github.io#17

@rzr
Copy link
Copy Markdown

rzr commented Feb 7, 2025

Relate-to: #353 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants