Suggested update to manuscript and code example#33
Open
muaawiyahtucker wants to merge 7 commits intoaaron-recompile:mainfrom
Open
Suggested update to manuscript and code example#33muaawiyahtucker wants to merge 7 commits intoaaron-recompile:mainfrom
muaawiyahtucker wants to merge 7 commits intoaaron-recompile:mainfrom
Conversation
…ed some ideas about chapter 5 and a suggestion on how to make the explanation clearer.
aaron-recompile
requested changes
Apr 11, 2026
Owner
aaron-recompile
left a comment
There was a problem hiding this comment.
Hi — you're technically correct on both points. The even-Y requirement does apply to the internal key P pre-tweak, not to Q, and the d' vs d notation does conflict with BIP340 convention. I'll incorporate these corrections into the manuscript directly.
However I can't merge this PR as-is because ecc.py (+322 lines) introduces a custom ECC library that doesn't fit the existing code architecture. The manuscript and key-tweaking script changes are valid — if you want to resubmit with only those two files, I'll review again.
Either way, the technical catch on even-Y is the kind of thing that makes the book better. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written a suggested improvement to the course material and placed a detailed explanation in an issue here.
Here is the suggested code improvements