fix(ci): sign OCI artifacts by digest instead of tag #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changed - Capture digest from `helm push` output - Sign using `$REGISTRY/chart@sha256:...` instead of `$REGISTRY/chart:version` - Combined push and sign into single step for atomic operation This fixes Cosign deprecation warning about signing by tag and ensures we sign exactly the image we just pushed (more secure). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying helm-charts with
|
| Latest commit: |
4d6a8b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c5dac8a.helm-charts-76l.pages.dev |
| Branch Preview URL: | https://fix-cosign-sign-by-digest.helm-charts-76l.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Cosign deprecation warning by signing OCI artifacts by digest instead of tag.
Problem
Cosign warns when signing by tag (e.g.,
chart:0.2.1):Signing by tag is a security concern because the tag could point to a different image between push and sign operations.
Solution
helm pushoutput (format:Digest: sha256:...)chart@sha256:abc123...instead ofchart:versionChanges
publish-ghcr.yaml- Combined publish + sign, uses digestrelease-please.yaml- Combined push + sign, uses digestTest plan
gh workflow run publish-ghcr.yaml -f charts=all -f sign=true🤖 Generated with Claude Code