fix(ci): fix boolean comparison in publish-ghcr signing condition#26
Merged
fix(ci): fix boolean comparison in publish-ghcr signing condition#26
Conversation
### Fixed - Changed `default: 'true'` to `default: true` (string to boolean) - Changed `inputs.sign == 'true'` to `inputs.sign` (boolean comparison) The `type: boolean` input returns a boolean, not a string, so comparing to `'true'` (string) was always false, causing signing steps to skip. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying helm-charts with
|
| Latest commit: |
64214b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cfe480b9.helm-charts-76l.pages.dev |
| Branch Preview URL: | https://fix-publish-ghcr-boolean-con.helm-charts-76l.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the
publish-ghcrworkflow signing:Fix 1: Boolean comparison
The workflow input
signhastype: boolean, but the conditions used string comparison:Fix: Changed to
if: inputs.sign(use boolean directly)Fix 2: Sign by digest instead of tag
Cosign warns when signing by tag (e.g.,
chart:0.2.1) because the tag could point to a different image between push and sign. This is a security concern.Fix: Capture digest from
helm pushoutput and sign usingchart@sha256:...Also updated
release-please.yamlwith the same digest-based signing.Test plan
gh workflow run publish-ghcr.yaml -f charts=all -f sign=true🤖 Generated with Claude Code