Skip to content

weaken circular references #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greencoloured wants to merge 1 commit into
base: master
Choose a base branch
from
Open

weaken circular references #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/RPC/Switch/Client.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use Encode qw(encode_utf8 decode_utf8);
use File::Basename;
use IO::Handle;
use POSIX ();
use Scalar::Util qw(blessed refaddr);
use Scalar::Util qw(blessed refaddr weaken);
use Storable;
use Sys::Hostname;

Expand Down Expand Up @@ -91,7 +91,7 @@ sub new {
}

sub connect {
my $self = shift;
weaken (my $self = shift);

delete $self->ioloop->{__exit__};
delete $self->{auth};
Expand Down Expand Up @@ -133,13 +133,13 @@ sub connect {
$self->{auth} = 0;
return;
}
my $ns = MojoX::NetstringStream->new(stream => $stream);
$self->{ns} = $ns;
my $conn = $rpc->newconnection(
$self->{ns} = MojoX::NetstringStream->new(stream => $stream);
weaken (my $ns = $self->{ns});
$self->{conn} = $rpc->newconnection(
owner => $self,
write => sub { $ns->write(@_) },
);
$self->{conn} = $conn;
weaken (my $conn = $self->{conn});
$ns->on(chunk => sub {
my ($ns2, $chunk) = @_;
#say 'got chunk: ', $chunk;
Expand Down Expand Up @@ -535,6 +535,7 @@ sub rpc_ping {
sub _magic {
#say '_magic: ', Dumper(\@_);
my ($self, $action, $con, $request, $rpccb) = @_;
weaken $con;
my $method = $request->{method};
my $req_id = $request->{id};
unless ($action) {
Expand Down Expand Up @@ -626,6 +627,8 @@ sub _magic {
sub _subproc {
my ($self, $cb, $action, $req_id, @args) = @_;

weaken $self;

# based on Mojo::IOLoop::Subprocess
my $ioloop = $self->ioloop;

Expand Down