Add LibraryInitializer registration tests#483
Merged
Conversation
b1b1683 to
993a9c5
Compare
JesusMcCloud
approved these changes
Jan 21, 2026
Collaborator
JesusMcCloud
left a comment
There was a problem hiding this comment.
I, for one, welcome our AI overlords!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LibraryInitializer.registerExtensionLibrarycorrectly registers credential schemes and polymorphic serializers forCredentialSubjectsubtypes.jsonValueEncoderandCborCredentialSerializerso values can be encoded/decoded inIssuerSignedIteminstances.Description
src/commonTest/kotlin/at/asitplus/wallet/lib/LibraryInitializerTest.ktcontaining tests that register a dummyCredentialSchemeand aSerializersModulewith a testCredentialSubjectsubclass.TestCredentialSchemeimplementation and validate registration viaAttributeIndex.resolveAttributeType(...)for thevcTypelookup.jsonValueEncoderanditemValueSerializerMap, assertsJsonCredentialSerializer.encode(...)behavior, and performs a CBOR round-trip usingIssuerSignedItemSerializerandcoseCompliantSerializer.Testing
LibraryInitializerTest.ktwas added that exercisesLibraryInitializer.registerExtensionLibraryand ISO encoder/serializer round-trip behavior, but it has not been run in CI for this PR.Codex Task