-
Notifications
You must be signed in to change notification settings - Fork 36
Add fpga digital twins article #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
immo-huneke-zuhlke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might be able to use the footnote syntax in Markdown language: see https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/
I have run out of time and only got as far as "Reusing the python testbench". I'll try to pick this up again later, but in the meantime you might wish to pass the rest of the text through a style checker (e.g. copy and paste the rendered markdown to MS Word).
rewrite and fix typos
immo-huneke-zuhlke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It reads much more fluently now. I have just two suggestions:
- make sure cocotb is spelled consistently (currently the T is sometimes upper case)
- the first time you mention cocotb, make it a hyperlink to the cocotb home page
harmonize caps
|
Thanks for reviewing @immo-huneke-zuhlke ! I harmonized cocotb and Python, the hyperlink should already bee there on the first occurence of cocotb. |
an article about FPGA engineering together with digital twins in python