Dev

README.md

@@ -19,7 +19,7 @@ For detailed guides on setup, configuration, and feature usage, please visit our
 
 ## Supported Versions
 
-- Primary targets: **1.20.6 / 1.21.X**
+- Primary targets: **1.21.11 / 26.1.2**
 - Actual supported versions are detected at runtime via the `VersionChecker`
 - The plugin automatically disables itself on unsupported versions
 
@@ -345,4 +345,4 @@ Copyright © **ZonePractice contributors**
 
 ## Contact
 
-For issues, feature requests or contributions, use the project’s GitHub issue tracker.
+For issues, feature requests or contributions, use the project’s GitHub issue tracker.

SUMMARY.md

@@ -0,0 +1,27 @@
+# Table of contents
+
+* [✌️ ZonePractice Pro](README.md)
+
+## Overview
+
+* [💡 Getting Started](overview/getting-started.md)
+
+## Setup Guides
+
+* [⚔️ Ladder Setup](setup-guides/ladder-setup.md)
+* [🧊 Arena Setup](setup-guides/arena-setup.md)
+* [🎮 Event Setup](setup-guides/event-setup.md)
+* [✡️ Hologram Setup](setup-guides/hologram-setup.md)
+
+## Informations
+
+* [📜 Configuration Files](informations/configuration-files.md)
+* [⚙️ Commands](informations/commands.md)
+* [📚 Permissions](informations/permissions.md)
+
+## Extra
+
+* [9️⃣ Modern version Support Informations](extra/modern-version-support-informations.md)
+* [🧱 Placeholder API](extra/placeholder-api.md)
+* [🖥️ For Developers](extra/for-developers.md)
+* [❔ Support](extra/support.md)

core/src/main/java/dev/nandi0813/practice/ZonePractice.java

@@ -106,7 +106,7 @@ public void onEnable() {
         faststats_metrics.ready();
 
         if (VersionChecker.getBukkitVersion() == null) {
-            Common.sendConsoleMMMessage("<red>Unsupported server version! Please use 1.20.6 or 1.21.X");
+            Common.sendConsoleMMMessage("<red>Unsupported server version! Please use 1.21.11 or 26.1.2");
             Bukkit.getPluginManager().disablePlugin(this);
             return;
         }

core/src/main/java/dev/nandi0813/practice/listener/EntityDamage.java

@@ -21,9 +21,8 @@ public void onEntityDamage(EntityDamageEvent e) {
             Location lobbyLocation = ServerManager.getLobby();
             if (lobbyLocation != null)
                 player.teleport(lobbyLocation);
+            e.setCancelled(true);
         }
-
-        e.setCancelled(true);
     }
 
 }

core/src/main/java/dev/nandi0813/practice/listener/PlayerJoin.java

@@ -30,9 +30,12 @@ public class PlayerJoin implements Listener {
     public void onPlayerJoin(PlayerJoinEvent e) {
         final Player player = e.getPlayer();
         final UUID uuid = player.getUniqueId();
-        e.joinMessage(Component.empty());
-
         Profile profile = ProfileManager.getInstance().getProfile(player);
+
+        // Suppress default join message if disabled in config
+        if (!ConfigManager.getBoolean("PLAYER.JOIN-MESSAGE"))
+            e.joinMessage(Component.empty());
+
         if (profile == null)
             profile = ProfileManager.getInstance().newProfile(player, uuid);
 

core/src/main/java/dev/nandi0813/practice/listener/PlayerQuit.java

@@ -38,7 +38,6 @@ public void onPlayerQuit(PlayerQuitEvent e) {
 
         MessageCommand.latestMessage.remove(player);
         MessageCommand.latestMessage.values().removeIf(target -> target.equals(player));
-        ProfileManager.getInstance().clearPlayerReference(player);
 
         final Profile profile = ProfileManager.getInstance().getProfile(player);
         final Party party = PartyManager.getInstance().getParty(player);
@@ -68,6 +67,8 @@ public void onPlayerQuit(PlayerQuitEvent e) {
                         ProfileManager.getInstance().demoteOfflineProfile(uuid), 40L);
             }
         }
+
+        ProfileManager.getInstance().clearPlayerReference(player);
     }
 
     @EventHandler(priority = EventPriority.LOWEST)
@@ -83,20 +84,24 @@ public void onPlayerKick(PlayerKickEvent e) {
 
         MessageCommand.latestMessage.remove(player);
         MessageCommand.latestMessage.values().removeIf(target -> target.equals(player));
-        ProfileManager.getInstance().clearPlayerReference(player);
 
         MatchManager.getInstance().invalidateRematchByPlayer(player);
 
         Profile profile = ProfileManager.getInstance().getProfile(player);
         if (profile != null) {
             profile.getActionBar().resetForReconnect();
+            profile.setLastJoin(System.currentTimeMillis());
 
             if (ZonePractice.getInstance().isEnabled()) {
                 UUID uuid = player.getUniqueId();
-                Bukkit.getScheduler().runTaskLater(ZonePractice.getInstance(), () ->
-                        ProfileManager.getInstance().demoteOfflineProfile(uuid), 40L);
+                Bukkit.getScheduler().runTaskLater(ZonePractice.getInstance(), () -> {
+                    profile.setStatus(ProfileStatus.OFFLINE);
+                    ProfileManager.getInstance().demoteOfflineProfile(uuid);
+                }, 40L);
             }
         }
+
+        ProfileManager.getInstance().clearPlayerReference(player);
     }
 
 }

core/src/main/java/dev/nandi0813/practice/manager/arena/arenas/interfaces/NormalArena.java

@@ -15,7 +15,6 @@
 @Setter
 public abstract class NormalArena extends BasicArena implements DisplayName {
 
-    // Not used yet
     protected boolean portalProtection = false;
     protected int portalProtectionValue;
 

core/src/main/java/dev/nandi0813/practice/manager/arena/listener/ArenaCopyUtilListener.java

@@ -293,6 +293,9 @@ public void run() {
     }
 
     protected void deleteNormal(final String arena, final Cuboid cuboid) {
+        // Remove all non-player entities before deleting blocks
+        removeNonPlayerEntities(cuboid);
+
         // OPTIMIZATION: Use iterator directly instead of creating a full list in memory
         final Iterator<Block> iterator = cuboid.iterator();
 

core/src/main/java/dev/nandi0813/practice/manager/arena/setup/ArenaSetupListener.java

@@ -330,7 +330,9 @@ private void handleBuildMax(Player player, DisplayArena arena, Action action) {
         if (action.name().contains("LEFT")) {
             arena.setBuildMax(false);
             arena.setBuildMaxValue(ConfigManager.getInt("MATCH-SETTINGS.BUILD-LIMIT-DEFAULT"));
-            Common.sendMMMessage(player, "<red>Build Height Limit disabled for " + arena.getName());
+            arena.setData();
+            Common.sendMMMessage(player, "<red>Build Height Limit disabled for " + arena.getName() +
+                    " <gray>(now relative: spawn Y + " + ConfigManager.getInt("MATCH-SETTINGS.BUILD-LIMIT-DEFAULT") + " blocks — use right-click to set an absolute limit)");
             return;
         }
 
@@ -341,6 +343,7 @@ private void handleBuildMax(Player player, DisplayArena arena, Action action) {
 
         arena.setBuildMaxValue(pos.getBlockY());
         arena.setBuildMax(true);
+        arena.setData();
 
         Common.sendMMMessage(player, LanguageManager.getString("COMMAND.ARENA.ARGUMENTS.SETBUILDMAX.SET-BUILDMAX")
                 .replace("%arena%", arena.getName())

core/src/main/java/dev/nandi0813/practice/manager/arena/util/ArenaUtil.java

@@ -151,19 +151,21 @@ public static boolean changeStatus(Player player, DisplayArena arena) {
             }
         }
 
+        arena.setEnabled(!arena.isEnabled());
+        arena.setData();
+
         if (arena instanceof FFAArena) {
             FFA ffa = ((FFAArena) arena).getFfa();
 
             if (ffa != null) {
                 if (arena.isEnabled()) {
-                    ffa.close("");
-                } else {
                     ffa.open();
+                } else {
+                    ffa.close("");
                 }
             }
         }
 
-        arena.setEnabled(!arena.isEnabled());
         return true;
     }
 
@@ -233,16 +235,16 @@ public static boolean containsDestroyableBlock(Ladder ladder, Block block) {
 
     public static boolean requiresSupport(Block block) {
         Material type = block.getType();
-        return org.bukkit.Tag.FLOWERS.isTagged(type)
-                || org.bukkit.Tag.SAPLINGS.isTagged(type)
-                || org.bukkit.Tag.CROPS.isTagged(type)
-                || org.bukkit.Tag.WALL_POST_OVERRIDE.isTagged(type)   // torches, signs on walls, etc.
+        return Tag.FLOWERS.isTagged(type)
+                || Tag.SAPLINGS.isTagged(type)
+                || Tag.CROPS.isTagged(type)
+                || Tag.WALL_POST_OVERRIDE.isTagged(type)   // torches, signs on walls, etc.
                 || type == Material.DEAD_BUSH
                 || type == Material.SHORT_GRASS
                 || type == Material.TALL_GRASS
                 || type == Material.FERN
                 || type == Material.LARGE_FERN
-                || type == Material.VINE
+                || type.name().equals("VINE") || type.name().contains("_VINE") || type.name().contains("_VINES")
                 || type == Material.SUGAR_CANE
                 || type == Material.CACTUS
                 || type == Material.SNOW

core/src/main/java/dev/nandi0813/practice/manager/fight/ffa/FFAListener.java

@@ -79,14 +79,14 @@ public void onPlayerInteract(PlayerInteractEvent e) {
 
         FFA ffa = FFAManager.getInstance().getFFAByPlayer(player);
         if (ffa == null) return;
-        
+
         // Prevent interaction while waiting for kit selection
         if (ffa.isPlayerWaitingForKitSelection(player)) {
             ffa.playerSelectKit(player, player.getInventory().getHeldItemSlot());
             e.setCancelled(true);
             return;
         }
-        
+
         if (!action.equals(Action.RIGHT_CLICK_AIR) && !action.equals(Action.RIGHT_CLICK_BLOCK)) return;
 
         Block clickedBlock = e.getClickedBlock();
@@ -220,7 +220,7 @@ public void onBlockBreak(BlockBreakEvent e) {
         if (ListenerUtil.handlePlacedInFightBlock(block, e)) return;
 
         // For natural arena blocks or destroyable blocks, check build limits
-        if (e.getBlock().getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(ffa.getArena())) {
+        if (ffa.getArena().isBuildMax() && e.getBlock().getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(ffa.getArena())) {
             Common.sendMMMessage(player, LanguageManager.getString("FFA.GAME.CANT-BUILD-OVER-LIMIT"));
             e.setCancelled(true);
             return;
@@ -272,7 +272,7 @@ public void onBlockPlace(BlockPlaceEvent e) {
             return;
         }
 
-        if (block.getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(arena)) {
+        if (arena.isBuildMax() && block.getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(arena)) {
             Common.sendMMMessage(player, LanguageManager.getString("FFA.GAME.CANT-BUILD-OVER-LIMIT"));
             e.setCancelled(true);
         }
@@ -302,7 +302,7 @@ public void onBucketEmpty(PlayerBucketEmptyEvent e) {
             return;
         }
 
-        if (block.getRelative(e.getBlockFace()).getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(ffa.getArena())) {
+        if (ffa.getArena().isBuildMax() && block.getRelative(e.getBlockFace()).getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(ffa.getArena())) {
             Common.sendMMMessage(player, LanguageManager.getString("FFA.GAME.CANT-BUILD-OVER-LIMIT"));
             e.setCancelled(true);
         }
@@ -389,6 +389,9 @@ public void onPlayerDeath(PlayerDeathEvent e) {
         Player killer = resolveKiller(player, ffa, damageSource);
 
         DeathCause cause = FightUtil.convert(damageSource.getDamageType());
+        if (cause == DeathCause.EXPLOSION && killer != null && !killer.equals(player)) {
+            cause = DeathCause.EXPLOSION_BY_PLAYER;
+        }
         ffa.killPlayer(player, killer, cause.getMessage().replace("%killer%", killer != null ? killer.getName() : "Unknown"));
 
         if (killer != null && !killer.equals(player)) {
@@ -484,4 +487,4 @@ public void onEntityDamage(EntityDamageEvent e) {
         }
     }
 
-}
+}

core/src/main/java/dev/nandi0813/practice/manager/fight/listener/BuildListener.java

@@ -337,6 +337,32 @@ public void onBlockPlace(BlockPlaceEvent event) {
         }
     }
 
+    /**
+     * Captures support-dependent blocks for rollback before physics removes them.
+     * <p>
+     * Uses the <b>source block</b> of the physics event (the block that changed,
+     * triggering neighbor physics) to look up the owning fight — O(1) check instead
+     * of scanning all active fights for every affected neighbor.
+     * <p>
+     * At LOWEST priority the affected block still holds its original material,
+     * so we snapshot it before physics turns it to air.
+     */
+    @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
+    public void onBlockPhysics(BlockPhysicsEvent e) {
+        Block block = e.getBlock();
+
+        if (!ArenaUtil.requiresSupport(block)) return;
+        if (BlockUtil.hasMetadata(block, PLACED_IN_FIGHT)) return;
+
+        Block source = e.getSourceBlock();
+        if (source == null) return;
+
+        Spectatable spectatable = getByBlock(source);
+        if (spectatable == null || !spectatable.isBuild()) return;
+
+        spectatable.getFightChange().addArenaBlockChange(new ChangedBlock(block));
+    }
+
     @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
     public void onBlockIgnite(BlockIgniteEvent event) {
         Block ignitedBlock = event.getBlock();

core/src/main/java/dev/nandi0813/practice/manager/fight/match/Match.java

@@ -143,6 +143,7 @@ public void startMatch() {
             for (Player online : Bukkit.getOnlinePlayers()) {
                 if (!this.players.contains(online)) {
                     PlayerHider.getInstance().hidePlayer(player, online, true);
+                    PlayerHider.getInstance().hidePlayer(online, player, false);
                 }
             }
 

core/src/main/java/dev/nandi0813/practice/manager/fight/match/listener/LadderTypeListener.java

@@ -84,7 +84,7 @@ protected boolean isWithinBuildLimits(Block block, Match match, Player player) {
         // Check height limit
         // Note: The limit represents the maximum Y coordinate blocks can reach (top of block)
         // Since blocks occupy Y to Y+1, we check if the block's position (bottom) is >= limit
-        if (block.getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(match.getArena())) {
+        if (match.getArena().isBuildMax() && block.getLocation().getY() >= ListenerUtil.getCalculatedBuildLimit(match.getArena())) {
             Common.sendMMMessage(player, LanguageManager.getString("MATCH.CANT-BUILD-OVER-LIMIT"));
             return false;
         }
@@ -691,8 +691,12 @@ public void onPlayerDeath(PlayerDeathEvent e) {
         }
 
         DeathCause cause = FightUtil.convert(damageSource.getDamageType());
+        if (cause == DeathCause.EXPLOSION && killer != null && !killer.equals(player)) {
+            cause = DeathCause.EXPLOSION_BY_PLAYER;
+        }
+        DeathCause finalCause = cause;
         Bukkit.getScheduler().runTaskLater(ZonePractice.getInstance(), () ->
-                match.killPlayer(player, killer, cause.getMessage().replace("%killer%", killer != null ? killer.getName() : "Unknown")), 1L);
+                match.killPlayer(player, killer, finalCause.getMessage().replace("%killer%", killer != null ? killer.getName() : "Unknown")), 1L);
 
         if (killer != null) {
             Statistic statistic = match.getCurrentStat(killer);
@@ -898,4 +902,4 @@ private static boolean shouldDelegateExplosiveByEntityDamageToLadder(EntityDamag
         return ladderType == LadderType.FIREBALL_FIGHT || ladderType == LadderType.TNT_SUMO;
     }
 
-}
+}

core/src/main/java/dev/nandi0813/practice/manager/fight/match/listener/MatchEventListener.java

@@ -84,6 +84,8 @@ public void onPlayerChooseKit(PlayerInteractEvent e) {
         if (match == null) return;
 
         MatchFightPlayer matchFightPlayer = match.getMatchPlayers().get(player);
+        if (matchFightPlayer == null) return;
+
         if (!matchFightPlayer.isHasChosenKit()) {
             e.setCancelled(true);
 
@@ -108,6 +110,8 @@ public void onPlayerChooseKit(InventoryClickEvent e) {
         if (match == null) return;
 
         MatchFightPlayer matchFightPlayer = match.getMatchPlayers().get(player);
+        if (matchFightPlayer == null) return;
+
         if (!matchFightPlayer.isHasChosenKit()) {
             e.setCancelled(true);
         }

core/src/main/java/dev/nandi0813/practice/manager/fight/match/type/duel/Duel.java

@@ -14,6 +14,7 @@
 import dev.nandi0813.practice.manager.fight.match.util.TeamUtil;
 import dev.nandi0813.practice.manager.fight.match.util.TempKillPlayer;
 import dev.nandi0813.practice.manager.inventory.InventoryManager;
+import dev.nandi0813.practice.manager.nametag.NametagManager;
 import dev.nandi0813.practice.manager.ladder.abstraction.Ladder;
 import dev.nandi0813.practice.manager.ladder.abstraction.interfaces.DeathResult;
 import dev.nandi0813.practice.manager.ladder.abstraction.normal.NormalLadder;
@@ -61,6 +62,10 @@ public Duel(Ladder ladder, Arena arena, List<Player> players, boolean ranked, in
         } else {
             this.player2 = null;
         }
+
+        NametagManager.getInstance().setNametag(player1, TeamEnum.TEAM1.getPrefix(), TeamEnum.TEAM1.getNameColor(), TeamEnum.TEAM1.getSuffix(), 20);
+        if (player2 != null)
+            NametagManager.getInstance().setNametag(player2, TeamEnum.TEAM2.getPrefix(), TeamEnum.TEAM2.getNameColor(), TeamEnum.TEAM2.getSuffix(), 21);
     }
 
     @Override
@@ -190,6 +195,7 @@ public void removePlayer(Player player, boolean quit) {
         if (!players.contains(player)) return;
 
         players.remove(player);
+        matchPlayers.remove(player);
         MatchManager.getInstance().getPlayerMatches().remove(player);
 
         // Only process quit logic if the match hasn't ended yet