Skip to content

Implement velocity checks and logging in KnockbackUtil #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linsaftw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement velocity checks and logging in KnockbackUtil #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/main/java/dev/nandi0813/practice/Manager/Match/Util/KnockbackUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@

import dev.nandi0813.practice.Manager.File.ConfigManager;
import dev.nandi0813.practice.Manager.Ladder.KnockbackType;
import org.bukkit.Bukkit;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.util.Vector;

import java.util.logging.Logger;

public class KnockbackUtil {
private static final double MAX_VELOCITY_COMPONENT = 4.0;

/**
* It sets the knockback of a player based on the knockback type
Expand All @@ -15,12 +20,10 @@ public class KnockbackUtil {
*/
public static void setPlayerKnockback(Entity player, KnockbackType knockbackType) {
if (!ConfigManager.getConfig().getBoolean("knockback.enabled", true)) return;

int airhorizontal = ConfigManager.getConfig().getInt("knockback." + knockbackType.toString().toLowerCase() + ".air-horizontal");
int airvertical = ConfigManager.getConfig().getInt("knockback." + knockbackType.toString().toLowerCase() + ".air-vertical");
int horizontal = ConfigManager.getConfig().getInt("knockback." + knockbackType.toString().toLowerCase() + ".horizontal");
int vertical = ConfigManager.getConfig().getInt("knockback." + knockbackType.toString().toLowerCase() + ".vertical");

Vector vel = player.getVelocity();
if (player.isOnGround()) {
vel.setX(vel.getX() * horizontal);
Expand All @@ -31,7 +34,19 @@ public static void setPlayerKnockback(Entity player, KnockbackType knockbackType
vel.setZ(vel.getZ() * airhorizontal);
vel.setY(vel.getY() * airvertical);
}
if (Math.abs(vel.getX()) > MAX_VELOCITY_COMPONENT
|| Math.abs(vel.getY()) > MAX_VELOCITY_COMPONENT
|| Math.abs(vel.getZ()) > MAX_VELOCITY_COMPONENT) {
Logger logger = Bukkit.getLogger();
String name = player.getName() != null ? player.getName() : player.getType().name();
String message = "Excessive velocity detected for " + name + ": x=" + vel.getX() + ", y=" + vel.getY() + ", z=" + vel.getZ();
logger.warning(message);
if (player instanceof Player) {
Player p = (Player) player;
p.sendMessage(message);
}
return;
}
player.setVelocity(vel);
}

}