test: FR-007 Eventually tests + full CI/CD + v0.5.0 release#17
Open
ZoneCNH wants to merge 4 commits into
Open
Conversation
Align CI/CD execution with the shared SRE pool contract and keep release jobs on deployment capacity. Constraint: Base modules must run CI/CD on sre/* machine pools. Confidence: high Scope-risk: moderate Directive: Keep module CI jobs pinned to their module-specific sre/* pool and release jobs on sre/deploy. Tested: YAML parse and runner policy scan across present base modules; git diff --check across present base modules; targeted Go checks for kernel, bootstrap, ossx, clickhousex, and postgresx. Not-tested: Full Go test/vet was not rerun for every unchanged-code module; xlib-harness and xlib-evidence are absent locally.
Eventually signature *testing.T→testing.TB (backward compatible: *testing.T implements testing.TB) to make the fail path testable. Adds 8 subtests covering all AC-007 branches: success within timeout, timeout failure, zero/negative timeout single-check, nil predicate, default interval. Closes the FR-007 / AC-007 / TC-007 coverage gap (eventually.go was 0%). Co-Authored-By: Claude <noreply@anthropic.com>
Replace minimal ci.yml with the complete template (module/testkitx/ci-workflow.yaml): preflight, build, test, lint, boundary (xlibgate trust), testkitx-gates (no-production-import / contract / golden-update-guard / coverage-threshold / deps-tidy), integration, secret-scan, evidence, release pipeline — all on sre/foundation-l1 (CI) / sre/deploy (CD) pools. Remove duplicate integration.yml. Co-Authored-By: Claude <noreply@anthropic.com>
- version.go / .repo-contract.yaml: v0.4.0 → v0.5.0 - CHANGELOG v0.5.0: Eventually tests (FR-007), full CI/CD, acceptance evidence (build/vet/race exit=0, coverage 92.6%, AC/TC 001-010 all passing) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[module: testkitx]
Changes
pkg/testkitx/eventually_test.go— FR-007Eventuallyunit tests (8 subtests, coverage 0%→100%). Signature*testing.T→testing.TB(backward compatible) to make the fail path testable. Closes the AC-007/TC-007 gap..github/workflows/ci.yml) — preflight/build/test/lint/boundary/testkitx-gates (no-production-import / contract / golden-update-guard / coverage-threshold / deps-tidy / gitleaks) / integration / secret-scan / evidence / release pipeline, all onsre/foundation-l1(CI) /sre/deploy(CD). Removed duplicateintegration.yml.Verification
go build ./.../go vet ./.../go test ./... -race -count=1: all exit=0eventually.go Eventually: 100% (was 0%)Release
Tag
v0.5.0pushed; release CI (release.yml + ci.yml release-publish) will create the GitHub release.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com