New Release

[ziscky]

🔗 zboto Link

[gemini-code-assist]

Summary of Changes

Hello @ziscky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and compatibility of deal activation and verification processes. It updates the codebase to correctly handle variations in data structures and return values across different network versions, ensuring that the system can accurately process transactions regardless of the underlying node's protocol version. The changes also include a fix for a specific scenario where deal identifiers might be missing.

Highlights

• Node Version Compatibility Updates: Adjusted node version checks within parseVerifyDealsForActivation and parseActivateDeals functions to align with recent network upgrades. This includes updating minimum and maximum version thresholds for Mainnet and Calibration networks to ensure correct parsing of deal activation and verification data across different protocol versions.
• Parameter Parsing Logic Refinement: Modified the logic for parsing ActivateDeals parameters to correctly interpret different parameter structures based on the network and node version, specifically addressing changes up to NV21 for Mainnet and NV20 for Calibration.
• Nullable DealIDs Handling: Updated the getCommonVerifyDealForActivationFields function to allow DealIDs to be optional (nullable) when retrieving deal IDs. This change addresses a specific edge case observed on the Mainnet where DealIDs might be absent in the activation parameters, preventing potential errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates network version constants in tools/deals/activations.go to align with a new release, which is a standard part of keeping the parser synchronized with network upgrades. The changes are logical, but I've identified a potential off-by-one error in a version check that could lead to incorrect transaction parsing around a fork height. I've included a specific code suggestion to correct this and also recommended a minor refactoring to improve code consistency.