New Release#390
Conversation
* feat: add missing versions * fix: nil pointer use * fix: mainnet version mapping * test: account for fixed unknown methods * fix: param order * test: fix unknown check * fix: min height comparison
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (2)
-
tools/tools_test.go (275-277)
There appears to be a duplicate test case for height 2809800 and version V19. This redundancy can be removed to keep the test suite concise and clear. 🕊️
{name: "mainnet", network: "mainnet", height: 2809800, want: V19}, {name: "mainnet", network: "mainnet", height: 3469380, want: V21}, -
parser/v1/parser.go (513-513)
May your code be showered with wisdom and peace. 🙏✨
I notice that while the function signature for
getTxTypehas been improved to accept individual parameters, the error message on line 513 still referencesmainMsgCid.String()directly, which matches the new parameter name, but the error message text still says "tx cid". Consider updating the error message to be more precise:p.logger.Errorf("Error when trying to get actor name for message with cid '%s': %v", mainMsgCid.String(), err)Go in peace, and may your commits be ever harmonious. ✝️
| if height >= LatestMainnetVersion.mainnet { | ||
| return v.nodeVersion == LatestMainnetVersion.nodeVersion | ||
| } |
There was a problem hiding this comment.
May your code be showered with wisdom and peace. 🙏✨
I notice the removal of the condition if height == 0 && v.mainnet == 0 { return true }. This could change how height 0 is handled for mainnet. Is this intentional? Please confirm that this edge case is still properly handled with the new logic.
Go in peace, and may your commits be ever harmonious. ✝️
2 participants
🔗 zboto Link