New Release#363
Merged
Merged
Conversation
…#362) * feat: add system actors whose robust address is not present for calib * chore: code improvements
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments: 0 Blocking, 0 Optional, 0 Nit, 1 FYI
- FYI: tools/version_mapping.go (10-12) FYI: Mamma mia! 🍝 I like this refactoring - adding the new constant makes the code more readable and maintainable. The alignment of the constants is *chef's kiss* 🤌 - just like perfectly aligned lasagna layers!
Comment on lines
+40
to
+42
| // CalibrationActorsId Map to identify system actors which don't have an associated robust address in the calibration network | ||
| // These are storage miners that initiated the calibration network | ||
| var CalibrationActorsId = map[string]bool{ |
There was a problem hiding this comment.
Mamma mia! 🍝 This new CalibrationActorsId map looks good, but the comment could use a bit more sauce! 🤌 Perhaps add more details about what these specific miners do in the calibration network and why they need special handling. It would help future developers understand the purpose better! 🍕
Comment on lines
+127
to
+131
| if tools.ParseRawNetworkName(a.networkName) == tools.CalibrationNetwork { | ||
| if _, ok := CalibrationActorsId[add.String()]; ok { | ||
| return add.String(), nil | ||
| } | ||
| } |
There was a problem hiding this comment.
That's-a nice calibration network check! 🤌 But it might be helpful to add a debug log message when we hit this special case. Without logging, it's like trying to find a meatball in a bowl of spaghetti! 🍝 This would make troubleshooting easier if someone wonders why a particular address is being handled differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.