New Release

[emmanuelm41]

No description provided.

[windsurf-bot]

Other comments: 0 Blocking, 0 Optional, 3 Nit, 2 FYI

• Nit: actors/v2/tools.go (126-130) Nit: Mamma mia! 🤌 This else block after the return statement is like putting pineapple on pizza - unnecessary! 🍕

  	if len(blockCids) == 0 {
  		return blockCid, errors.New("could not find block hash for message cid. Slice is empty")
  	}
  	blockCid = blockCids[0].Cid
  

• Nit: actors/v2/tools.go (99-99) Nit: That's a spicy typo! 🍝 'paramater' should be 'parameter' in this error message.

  		logger.Errorf("Could not get parameter 'Params' inside tx '%s'", txType)
  

• Nit: parser/v2/parser.go (374-375) Nit: Mamma mia! 🤌 You removed the newline after line 374 which makes the code look like a tangled plate of spaghetti! Let's keep our code as organized as a perfect lasagna layer.

  	txFrom, txTo := p.getFromToRobustAddresses(trace.Msg.From, trace.Msg.To)
  
  	return &types.Transaction{
  

• FYI: actors/v2/miner/miner.go (173-174) FYI: Mamma mia! 🍝 Good cleanup removing that debug print statement! It's always nice to remove these little debugging breadcrumbs when they're no longer needed - keeps the code as clean as fresh pasta! 🤌
• FYI: actors/cache/impl/zcache.go (301-302) FYI: Mamma mia! 🤌 Good catch on renaming the parameter from 'cid' to 'cidStr' to avoid confusion with the imported package. And adding that check for undefined CIDs? *chef's kiss* 🍝 That's-a smart defensive programming! Prevents storing undefined CIDs that would just create confusion later, like overcooked spaghetti! 🍝

[windsurf-bot]

Mamma mia! 🤌 You're ignoring errors from address.NewFromString() on lines 18 and 21. This is like making spaghetti without checking if the water is boiling! Consider handling these errors properly or at least logging them to avoid unexpected behavior.

Suggested change

	if err == nil {
	shortAddress, _ := address.NewFromString(shortAddressStr)
	addrStr, err := actorCache.GetRobustAddress(shortAddress)
	if err == nil {
	addr, _ = address.NewFromString(addrStr)
	}
	}
	shortAddress, err := address.NewFromString(shortAddressStr)
	if err != nil {
	logger.Warnf("Error converting short address %s: %v", shortAddressStr, err)
	} else {
	addrStr, err := actorCache.GetRobustAddress(shortAddress)
	if err == nil {
	addr, err = address.NewFromString(addrStr)
	if err != nil {
	logger.Warnf("Error converting robust address %s: %v", addrStr, err)
	}
	}
	}

[windsurf-bot]

That's a spicy meatball! 🍕 The comment says these cases would cause compile-time errors, but it doesn't explain why. If these types have the same structure but would cause errors due to Go's type system, consider adding a more detailed comment explaining the situation. Otherwise, future developers might try to uncomment these lines and get confused. Clarity is the secret ingredient in good code, just like in a perfect marinara! 🍝