Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds macOS 10.15 (Catalina) support to the Swift package by specifying a minimum platform version and adding a Swift compilation setting for library embedding.
- Adds macOS 10.15 as the minimum supported platform
- Includes Swift setting to always embed Swift standard libraries
- Updates package target configuration formatting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| name: "lib-rust", | ||
| swiftSettings: [ | ||
| .define("SWIFT_PACKAGE_ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES") | ||
| ]) |
There was a problem hiding this comment.
The SWIFT_PACKAGE_ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES define is typically used for C/C++ targets that need to link with Swift libraries, but this appears to be applied to a Swift target named 'lib-rust'. This setting may not be necessary or appropriate for a pure Swift target. Consider whether this define is actually needed for your use case.
Suggested change
| ]) | |
| // swiftSettings intentionally left empty; removed unnecessary define | |
| ]) |
The new pattern matches all CLI artifacts without platform-specific suffixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.