Vinscant rust #69
Merged
Vinscant rust #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wifi works http request works
TODO make student card works
basically tuning it
hannes-dev
requested changes
Jul 10, 2025
Member
hannes-dev
left a comment
hannes-dev
left a comment
There was a problem hiding this comment.
Nice! Most of your code seems really good and you show a good understanding of most Rust syntax, but some slight tweaks can be made!
Co-authored-by: Hannes <hannes-dev@mailbox.org>
vinscant: code cleanup
hannes-dev
reviewed
Jul 25, 2025
hannes-dev
reviewed
Jul 25, 2025
hannes-dev
approved these changes
Aug 21, 2025
Member
hannes-dev
left a comment
hannes-dev
left a comment
There was a problem hiding this comment.
Looks really nice overall :)
| leds: 8, | ||
| idle_effect: Box::new(PingPong::new(8, vec![Srgb::new(0xff, 0x7f, 0x00)])), | ||
| buzzer, | ||
| mqtt_client: EspMqttClient::new("mqtt://192.168.0.12:1883", &MqttClientConfiguration{ |
Member
There was a problem hiding this comment.
Probably not a big deal, but would it be better for this to be a XXX.kelder.local instead?
Contributor
Author
There was a problem hiding this comment.
Dns does not work correctly for some reason
Comment on lines
+123
to
+125
| if let Ok(answer) = scanner.reqa() { | ||
| if let Ok(uid) = scanner.select(&answer) { | ||
| if uid.as_bytes() == last_uid.as_bytes() && get_time() - last_time <= 15 { |
Member
There was a problem hiding this comment.
Suggested change
| if let Ok(answer) = scanner.reqa() { | |
| if let Ok(uid) = scanner.select(&answer) { | |
| if uid.as_bytes() == last_uid.as_bytes() && get_time() - last_time <= 15 { | |
| if let Ok(answer) = scanner.reqa() | |
| && let Ok(uid) = scanner.select(&answer) | |
| && uid.as_bytes() == last_uid.as_bytes() && get_time() - last_time <= 15 { |
also definitely not necessary, but if you want you could update to rust 1.88 and edition 2024 and use if let chains :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: