Skip to content

feat: add fee rate / miner fee toggle to refund swap view#4065

Open
shubhamkmr04 wants to merge 2 commits into
ZeusLN:masterfrom
shubhamkmr04:feat/refund-miner-fee
Open

feat: add fee rate / miner fee toggle to refund swap view#4065
shubhamkmr04 wants to merge 2 commits into
ZeusLN:masterfrom
shubhamkmr04:feat/refund-miner-fee

Conversation

@shubhamkmr04
Copy link
Copy Markdown
Contributor

@shubhamkmr04 shubhamkmr04 commented May 7, 2026

Description

In the submarine swap refund flow, we are now giving users option to add a exact miner Fee, alongside the existing fee rate input
related lnd changes ZeusLN/lnd#7

Simulator Screenshot - iPhone 17 Pro Max - 2026-05-07 at 16 11 32

This pull request is categorized as as:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

On-device

  • LDK Node
  • Embedded LND

Remote

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the option to specify either a fee rate or a total miner fee when performing an uncooperative refund. Changes include updates to the transaction creation logic, new localization strings, and a UI toggle using a ButtonGroup. Feedback highlights the need for more comprehensive validation in the refund button's disabled state, the use of substitution parameters instead of string concatenation for localized labels, and the addition of visual error feedback for the miner fee input field.

Comment thread views/Swaps/Refund.tsx Outdated
Comment thread views/Swaps/Refund.tsx
Comment thread views/Swaps/Refund.tsx
@kaloudis kaloudis added the Swaps On-chain <-> LN label May 7, 2026
@kaloudis kaloudis added this to the v13.1.0 milestone May 7, 2026
ajaysehwal

This comment was marked as resolved.

@shubhamkmr04 shubhamkmr04 force-pushed the feat/refund-miner-fee branch from 5131878 to e7d0cee Compare May 18, 2026 11:17
@shubhamkmr04 shubhamkmr04 force-pushed the feat/refund-miner-fee branch from e7d0cee to 592e3ff Compare May 25, 2026 15:14
@kaloudis kaloudis modified the milestones: v13.1.0, v13.2.0 May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Swaps On-chain <-> LN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants