feat: add fee rate / miner fee toggle to refund swap view#4065
Open
shubhamkmr04 wants to merge 2 commits into
Open
feat: add fee rate / miner fee toggle to refund swap view#4065shubhamkmr04 wants to merge 2 commits into
shubhamkmr04 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the option to specify either a fee rate or a total miner fee when performing an uncooperative refund. Changes include updates to the transaction creation logic, new localization strings, and a UI toggle using a ButtonGroup. Feedback highlights the need for more comprehensive validation in the refund button's disabled state, the use of substitution parameters instead of string concatenation for localized labels, and the addition of visual error feedback for the miner fee input field.
5131878 to
e7d0cee
Compare
e7d0cee to
592e3ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the submarine swap refund flow, we are now giving users option to add a exact miner Fee, alongside the existing fee rate input
related lnd changes ZeusLN/lnd#7
This pull request is categorized as as:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: