Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Zeus application by adding support for LDK Node, a Lightning Development Kit node. It introduces a new onboarding process to guide users through wallet creation and configuration, including options for Cashu ecash and self-custodial Lightning. The PR also integrates LSPS7 for channel lease extensions and VSS for cloud backups, providing a more robust and user-friendly experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new onboarding process and integrates LDK Node as a new embedded wallet option. The changes are extensive, touching native code for Android and iOS, backend abstractions, UI components, and application state management. My review focuses on a few key areas: a critical data type issue in the native bridge that could lead to incorrect balances, a bug in the message verification logic for the new LDK backend, and a minor leftover debug statement. All identified issues are valid and should be addressed. Overall, this is a significant and well-executed feature addition.
Note: Security Review did not run due to the size of the PR.
kaloudis
force-pushed
the
onboarding
branch
2 times, most recently
from
0c8e97d to
a1fe637
Compare
Screen.Recording.2026-03-30.at.10.10.44.PM.mov |
There was a problem hiding this comment.
Screen.Recording.2026-03-30.at.10.15.21.PM.mov
@kaloudis, I don’t think this navigation behavior looks correct.
…iscovery, extract MintReviewsModal component
…und images for light theme readability
There was a problem hiding this comment.
@kaloudis , i think we need to remove intro images refs from ios/zeus.xcodeproj/project.pbxproj , ios/link-assets-manifest.json and android/link-assets-manifest.json
| import TextInput from '../../components/TextInput'; | ||
|
|
||
| import CashuStore, { ScoredMint } from '../../stores/CashuStore'; | ||
| import SettingsStore from '../../stores/SettingsStore'; |
There was a problem hiding this comment.
nit: SettingsStore is unused
ajaysehwal
left a comment
ajaysehwal
left a comment
There was a problem hiding this comment.
@kaloudis, the “Donate to ZEUS” option is currently visible on iOS, so we should remove it. We should also remove the Payment Tips option from the onboarding flow
|
I don’t think the developer options look appropriate in the onboarding flow. 
|
kaloudis
force-pushed
the
onboarding
branch
2 times, most recently
from
3240d95 to
9ef4df5
Compare
kaloudis
force-pushed
the
onboarding
branch
2 times, most recently
from
d668246 to
61276de
Compare
kaloudis
force-pushed
the
onboarding
branch
2 times, most recently
from
9d95b0b to
edc8992
Compare
2 participants
Description
Relates to issue: ZEUS-2342
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: