Skip to content

Training: add a default garbage collection callback #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
supersergiy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Training: add a default garbage collection callback #1151

supersergiy wants to merge 1 commit into from

Conversation

@supersergiy
Copy link
Member

@supersergiy supersergiy commented Jan 24, 2026

closes #1029

@supersergiy supersergiy changed the title fix Training: add a default garbage collection callback Jan 24, 2026
@supersergiy
Copy link
Member Author

supersergiy commented Jan 24, 2026

@trivoldus28 do you have a fix to this in your branch?

@codecov
Copy link

codecov bot commented Jan 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (4319f65) to head (367a559).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         191      191           
  Lines        9922     9926    +4     
=======================================
+ Hits         9920     9924    +4     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trivoldus28
trivoldus28 reviewed Jan 26, 2026
View reviewed changes
zetta_utils/training/lightning/trainers/default.py

# Lightning requires save_checkpoint to be called on all ranks!
super().save_checkpoint(filepath, weights_only, storage_options)
super().save_checkpoint(filepath, weights_only or False, storage_options)
Copy link
Contributor

@trivoldus28 trivoldus28 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly. Let's just fix weights_only so it cannot be None (https://pytorch-lightning.readthedocs.io/en/1.6.5/api/pytorch_lightning.trainer.trainer.Trainer.html#pytorch_lightning.trainer.trainer.Trainer.save_checkpoint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trivoldus28 trivoldus28 trivoldus28 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Training: add a default garbage collection callback

3 participants

@supersergiy @trivoldus28