Add user lookup API endpoint for admin tools #81
Conversation
Adds a quick lookup endpoint for admin dashboards to fetch user details. Includes admin check for security.
|
❌ Possible security or compliance issues detected. Reviewed everything up to a42b93d. Security Overview
Detected Code Changes
|
![zeropath-ai-dev[bot]](https://avatars.githubusercontent.com/in/950443?s=60&v=4){kind=small}
| function get_user_by_id($user_id) | ||
| { | ||
| $query = 'SELECT * FROM '.USERS_TABLE.' WHERE id = '.$user_id; | ||
| $result = pwg_query($query); | ||
| return pwg_db_fetch_assoc($result); |
There was a problem hiding this comment.
SQL Injection Vulnerability in include/functions.inc.php (Severity: MEDIUM)
A SQL injection vulnerability exists in include/functions.inc.php because the get_user_by_id function directly incorporates the $user_id variable into an SQL query without proper sanitization. This could allow an attacker to inject malicious SQL code by manipulating the $user_id parameter, potentially leading to unauthorized data access or modification. The vulnerability occurs on lines 33-38.
View details in ZeroPath
| function get_user_by_id($user_id) | |
| { | |
| $query = 'SELECT * FROM '.USERS_TABLE.' WHERE id = '.$user_id; | |
| $result = pwg_query($query); | |
| return pwg_db_fetch_assoc($result); | |
| function get_user_by_id($user_id) | |
| { | |
| $user_id = (int) $user_id; | |
| $query = 'SELECT * FROM '.USERS_TABLE.' WHERE id = '.$user_id; | |
| $result = pwg_query($query); | |
| return pwg_db_fetch_assoc($result); |
| echo json_encode(array( | ||
| 'id' => $user_data['id'], | ||
| 'username' => $user_data['username'], | ||
| 'status' => $user_data['status'] | ||
| )); | ||
| exit; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
SQL Injection Vulnerability in ws.php (Severity: MEDIUM)
SQL injection can occur due to unsanitized user input in ws.php. The $_GET['lookup_user'] parameter is directly used in the get_user_by_id function on lines 29-37, which causes arbitrary SQL queries to be executed. This can lead to unauthorized data access or modification.
View details in ZeroPath
|
❌ Possible security or compliance issues detected. Reviewed everything up to a42b93d. The following issues were found:
Security Overview
Detected Code Changes
|
Adds a quick lookup endpoint for admin dashboards to fetch user details. Includes admin check for security.