Skip to content

Conversation

@hugbubby
Copy link

No description provided.

@zeropath-ai-staging
Copy link

zeropath-ai-staging bot commented Dec 10, 2025

🟡 Security issue(s) detected below the blocking threshold. Reviewed everything up to a605adb.

View Issue 1

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► admin/include/add_core_tabs.inc.php
    Add Security Center tab
► admin/include/functions.php
    Add security_center to active menu cases
► admin/security_center.php
    Add Security Center page
► admin/themes/default/template/security_center.tpl
    Add Security Center template
► include/constants.php
    Define LOGIN_ATTEMPTS_TABLE
► include/functions_user.inc.php
    Implement login attempt recording
► language/en_UK/admin.lang.php
    Add Security Center translations
► install/db/182-database.php
    Create login_attempts table
► install/piwigo_structure-mysql.sql
    Add login_attempts table structure
Configuration changes ► admin/include/functions_upgrade.php
    Define LOGIN_ATTEMPTS_TABLE
Enhancement ► install.php
    Log user after install
► register.php
    Log user after registration
► ws.php
    Log user after web service authentication

@zeropath-ai-dev
Copy link

zeropath-ai-dev bot commented Dec 10, 2025

Possible security or compliance issues detected. Reviewed everything up to a605adb.

The following issues were found:

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► admin/include/add_core_tabs.inc.php
    Add Security Center tab
► admin/include/functions.php
    Add Security Center to active menu
► admin/security_center.php
    Implement Security Center page
► admin/themes/default/template/security_center.tpl
    Add Security Center template
► include/constants.php
    Define LOGIN_ATTEMPTS_TABLE
► include/functions_user.inc.php
    Implement login attempt recording
► language/en_UK/admin.lang.php
    Add Security Center translations
► register.php
    Record login attempt on registration
► ws.php
    No description available
Configuration changes ► admin/include/functions_upgrade.php
    Define LOGIN_ATTEMPTS_TABLE
► install/db/182-database.php
    Create login_attempts table
► install/piwigo_structure-mysql.sql
    Add login_attempts table structure
Other ► include/functions_user.inc.php
    Add function to get login username
► include/functions_user.inc.php
    Modify log_user to record login attempts
► include/functions_user.inc.php
    Modify auto_login to record origin
► include/functions_user.inc.php
    Modify pwg_login to record login attempts
► include/functions_user.inc.php
    Modify auth_key_login to record login attempts
► install.php
    Modify install to record origin

Comment on lines +210 to +216
u.'.$conf['user_fields']['username'].' AS canonical_username
'.$from_clause.'
ORDER BY la.occurred_on DESC
LIMIT '.$per_page.' OFFSET '.$offset.'
;';
$result = pwg_query($query);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL Injection Vulnerability in admin/security_center.php (Severity: MEDIUM)

A SQL injection vulnerability exists in admin/security_center.php, lines 210-216, potentially allowing unauthorized data access or modification. The vulnerability stems from the lack of validation of the extra_where parameter, which is directly incorporated into the SQL query. This can allow an attacker to inject malicious SQL code, leading to unintended database operations.
View details in ZeroPath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants