-
Notifications
You must be signed in to change notification settings - Fork 24
Updates #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Updates #33
Conversation
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, | ||
| 'IncCurrLabel' => Rubykassa.currency, | ||
| 'IncSum' => @total.to_s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| def calc_out_summ | ||
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, | ||
| 'IncCurrLabel' => Rubykassa.currency, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| def calc_out_summ | ||
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| self.login = 'your_login' | ||
| self.first_password = 'first_password' | ||
| self.second_password = 'second_password' | ||
| self.currency = 'currency' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary spacing detected.
Operator = should be surrounded by a single space.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| config.login = ENV['ROBOKASSA_LOGIN'] | ||
| config.first_password = ENV['ROBOKASSA_FIRST_PASSWORD'] | ||
| config.second_password = ENV['ROBOKASSA_SECOND_PASSWORD'] | ||
| config.currency = ENV['ROBOKASSA_CURRENCY'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| else | ||
| before_filter :create_notification | ||
| end | ||
| class RobokassaController < ApplicationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing magic comment # frozen_string_literal: true.
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, | ||
| 'IncCurrLabel' => Rubykassa.currency, | ||
| 'IncSum' => @total.to_s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| def calc_out_summ | ||
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, | ||
| 'IncCurrLabel' => Rubykassa.currency, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| def calc_out_summ | ||
| request transform_method_name(__method__), | ||
| 'MerchantLogin' => Rubykassa.login, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| self.login = 'your_login' | ||
| self.first_password = 'first_password' | ||
| self.second_password = 'second_password' | ||
| self.currency = 'currency' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary spacing detected.
Operator = should be surrounded by a single space.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| config.login = ENV['ROBOKASSA_LOGIN'] | ||
| config.first_password = ENV['ROBOKASSA_FIRST_PASSWORD'] | ||
| config.second_password = ENV['ROBOKASSA_SECOND_PASSWORD'] | ||
| config.currency = ENV['ROBOKASSA_CURRENCY'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| else | ||
| before_filter :create_notification | ||
| end | ||
| class RobokassaController < ApplicationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing magic comment # frozen_string_literal: true.
|
@ElusiveSpirit, привет! Давай зарелизим все на рубигемз. Я могу добавить тебя как коллаборатора в эту репу, чтобы прямо сюда коммитить |
#28