Skip to content

Conversation

@SergeyKishenin
Copy link
Member

#28

request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,
'IncCurrLabel' => Rubykassa.currency,
'IncSum' => @total.to_s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

def calc_out_summ
request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,
'IncCurrLabel' => Rubykassa.currency,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


def calc_out_summ
request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

self.login = 'your_login'
self.first_password = 'first_password'
self.second_password = 'second_password'
self.currency = 'currency'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.
Operator = should be surrounded by a single space.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

config.login = ENV['ROBOKASSA_LOGIN']
config.first_password = ENV['ROBOKASSA_FIRST_PASSWORD']
config.second_password = ENV['ROBOKASSA_SECOND_PASSWORD']
config.currency = ENV['ROBOKASSA_CURRENCY']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

else
before_filter :create_notification
end
class RobokassaController < ApplicationController

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,
'IncCurrLabel' => Rubykassa.currency,
'IncSum' => @total.to_s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

def calc_out_summ
request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,
'IncCurrLabel' => Rubykassa.currency,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


def calc_out_summ
request transform_method_name(__method__),
'MerchantLogin' => Rubykassa.login,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

self.login = 'your_login'
self.first_password = 'first_password'
self.second_password = 'second_password'
self.currency = 'currency'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.
Operator = should be surrounded by a single space.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

config.login = ENV['ROBOKASSA_LOGIN']
config.first_password = ENV['ROBOKASSA_FIRST_PASSWORD']
config.second_password = ENV['ROBOKASSA_SECOND_PASSWORD']
config.currency = ENV['ROBOKASSA_CURRENCY']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

else
before_filter :create_notification
end
class RobokassaController < ApplicationController

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

@SergeyKishenin
Copy link
Member Author

@ElusiveSpirit, привет! Давай зарелизим все на рубигемз. Я могу добавить тебя как коллаборатора в эту репу, чтобы прямо сюда коммитить

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage decreased (-0.7%) to 91.374% when pulling 998bffb on ElusiveSpirit:master into f946973 on ZeroOneStudio:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants