🎨 Palette: Localize Notification Channel Name#121
🎨 Palette: Localize Notification Channel Name#121manupawickramasinghe wants to merge 1 commit into
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR updates the app’s Android NotificationChannel to use user-facing, localized string resources for the channel name and description, instead of exposing the raw technical channel ID and hardcoded text in system Settings.
Changes:
- Added new string resources for the notification channel name and description.
- Updated
Camservice channel creation to use the new localized resources. - Documented the UI/accessibility learning in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds string resources for the notification channel’s name/description. |
| app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt | Uses localized strings when creating the NotificationChannel. |
| .Jules/palette.md | Records the notification-channel localization guidance for future work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| val channel = NotificationChannel( | ||
| CHANNEL_ID, | ||
| CHANNEL_ID, | ||
| getString(R.string.notification_channel_name), | ||
| NotificationManager.IMPORTANCE_DEFAULT | ||
| ) | ||
| channel.description = "RemoteCam run" | ||
| channel.description = getString(R.string.notification_channel_description) | ||
| val notificationManager = getSystemService(NotificationManager::class.java) | ||
| notificationManager.createNotificationChannel(channel) |
💡 What: Replaced the raw technical
CHANNEL_IDand hardcoded description string used for the app'sNotificationChannelwith localized string resources.🎯 Why: Android Notification Channel names and descriptions are exposed directly to users in the system Settings UI. Displaying technical identifiers like "REMOTE_CAM" or hardcoded strings without localization creates a confusing, unprofessional user experience.
📸 Before/After: N/A (System settings UI change)
♿ Accessibility: Ensures that users managing notifications through Android's system-level accessibility tools hear localized, human-readable channel names rather than confusing developer constants.
PR created automatically by Jules for task 7345365216320819360 started by @manupawickramasinghe