🎨 Palette: [UX improvement] Refine notification terminology#120
🎨 Palette: [UX improvement] Refine notification terminology#120manupawickramasinghe wants to merge 1 commit into
Conversation
Extract foreground service notification strings to `strings.xml` to support localization. Replaces technical and aggressive hardcoded strings (e.g. "Kill", "Click to open") with standard mobile UX terminology (e.g. "Stop", "Tap to open") to improve the user experience. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the UX and localization readiness of the app’s foreground-service notification by moving previously hardcoded notification/channel text in Cam.kt into Android string resources and updating terminology to be more user-friendly.
Changes:
- Extracted foreground service notification/channel strings into
strings.xml. - Updated notification copy from “Click/Kill” to “Tap/Stop” and replaced channel name/description with user-facing strings.
- Recorded the localization/notification-copy guideline in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new string resources for the notification channel/title/text/action. |
| app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt | Replaces hardcoded notification/channel UI strings with getString(...) resources. |
| .Jules/palette.md | Documents the new guidance about localizing system notification strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| val channel = NotificationChannel( | ||
| CHANNEL_ID, | ||
| CHANNEL_ID, | ||
| getString(R.string.notification_channel_name), | ||
| NotificationManager.IMPORTANCE_DEFAULT | ||
| ) | ||
| channel.description = "RemoteCam run" | ||
| channel.description = getString(R.string.notification_channel_desc) | ||
| val notificationManager = getSystemService(NotificationManager::class.java) | ||
| notificationManager.createNotificationChannel(channel) |
| .setContentText(getString(R.string.notification_text)).setOngoing(true) | ||
| .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop),pendingIntentKill) |
💡 What: Extracted hardcoded notification strings in
Cam.ktintostrings.xmland refined their terminology.🎯 Why: Using hardcoded strings like "Kill" or "Click to open" creates an unpolished, technical feel that cannot be localized. Refining these to "Stop" and "Tap" aligns with standard mobile UX patterns and allows the notification to adapt to the user's language settings.
📸 Before/After: N/A (System notification text changed from "RemoteCam (active) / Click to open" with a "Kill" button to localized string resources).
♿ Accessibility: Allows screen readers to correctly read translated notification text and action buttons in the user's preferred language.
PR created automatically by Jules for task 10025625331664791635 started by @manupawickramasinghe