Skip to content

🛡️ Sentinel: Unbounded String DoS in TableEntry & Privacy Obfuscation in IndeterminateProgressBar#87

Open
manupawickramasinghe wants to merge 2 commits into
mainfrom
sentinel-security-feature-iteration-11039801665327504496
Open

🛡️ Sentinel: Unbounded String DoS in TableEntry & Privacy Obfuscation in IndeterminateProgressBar#87
manupawickramasinghe wants to merge 2 commits into
mainfrom
sentinel-security-feature-iteration-11039801665327504496

Conversation

@manupawickramasinghe
Copy link
Copy Markdown
Member

🎯 Focus: Security Patch and Iterative Enhancement

💡 Context: As the application scales and supports larger CSV data imports, unbounded text fields pose a risk for Denial of Service via UI layout exceptions when rendered in IntrinsicColumnWidth(). Additionally, maintaining the momentum of the privacy obfuscation feature, all charts and progress components must handle temporary reveals.

🔧 Fix/Addition:

  • Implemented defensive truncation (500 character limit) to the headers and firstEntry fields inside budget/lib/widgets/tableEntry.dart to ensure stable UI rendering.
  • Refactored IndeterminateProgressBar in budget/lib/widgets/globalLoadingProgress.dart into a StatefulWidget equipped with touch gesture listeners (Listener), haptic feedback, and a 2-second auto-collapse timer to force the progress bar visually to 0.0 when global amount obfuscation is enabled.

📈 gemini.md Status: The gemini.md file has been updated to reflect the completion of the privacy obfuscation feature across all widgets, and the "Unbounded String Rendering DoS" vulnerability was logged under "Critical Security Learnings."

✅ Verification: Run flutter analyze and flutter test. Tested and passed natively.


PR created automatically by Jules for task 11039801665327504496 started by @manupawickramasinghe

…rative Improvement: Privacy Obfuscation] IndeterminateProgressBar

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings May 27, 2026 08:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses UI stability for long table text and extends privacy obfuscation behavior to the indeterminate loading/progress indicator, while updating the project ledger.

Changes:

  • Adds truncation for TableEntry header and first-row preview values.
  • Converts IndeterminateProgressBar to a stateful widget with temporary reveal behavior under amount obfuscation.
  • Updates gemini.md with privacy-mode completion and a new security learning entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
gemini.md Records the privacy obfuscation milestone and string-rendering DoS learning.
budget/lib/widgets/tableEntry.dart Truncates displayed table cell text before rendering.
budget/lib/widgets/globalLoadingProgress.dart Adds obfuscation-aware reveal behavior to the indeterminate progress bar.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


@override
Widget build(BuildContext context) {
String _truncate(String text) =>
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants