🛡️ Sentinel: Iterative Improvement: CategoryLimits Privacy Obfuscation#68
🛡️ Sentinel: Iterative Improvement: CategoryLimits Privacy Obfuscation#68manupawickramasinghe wants to merge 1 commit into
Conversation
🎯 Focus: Iterative Enhancement
💡 Context: The app's privacy mode ("Hide Balances") was partially implemented on `CategoryLimits`, but the main summary totals bypass obfuscation because they were missing the `forceReveal` argument.
🔧 Fix/Addition: Wrapped the summary `CountNumber` inside a `Listener` to handle hold-to-reveal gestures with a 2-second timeout. Passed `forceReveal: _isRevealed` to the internal `convertToMoney` and `convertToPercent` calls, and wrapped the text outputs in `AnimatedSwitcher` to ensure smooth transitions between revealed and obscured states.
📈 gemini.md Status: Updated Feature Iteration Track to log this addition to `CategoryLimits` and planned an audit of remaining custom widgets or progress bars.
✅ Verification: Ensure tests pass and the privacy reveal functions works on category summary limits.
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Sentinel: Iterative Improvement: CategoryLimits Privacy Obfuscation
🎯 Focus: Iterative Enhancement
💡 Context: The app's privacy mode ("Hide Balances") was partially implemented on
CategoryLimits, but the main summary totals bypass obfuscation because they were missing theforceRevealargument.🔧 Fix/Addition: Wrapped the summary
CountNumberinside aListenerto handle hold-to-reveal gestures with a 2-second timeout. PassedforceReveal: _isRevealedto the internalconvertToMoneyandconvertToPercentcalls, and wrapped the text outputs inAnimatedSwitcherto ensure smooth transitions between revealed and obscured states.📈 gemini.md Status: Updated Feature Iteration Track to log this addition to
CategoryLimitsand planned an audit of remaining custom widgets or progress bars.✅ Verification: Ensure tests pass and the privacy reveal functions works on category summary limits.
PR created automatically by Jules for task 9303806217693974743 started by @manupawickramasinghe