fix(mediascanner): prevent indefinite hangs on stale network mounts#549
Merged
wizzomafizzo merged 2 commits intomainfrom Mar 4, 2026
Merged
fix(mediascanner): prevent indefinite hangs on stale network mounts#549wizzomafizzo merged 2 commits intomainfrom
wizzomafizzo merged 2 commits intomainfrom
Conversation
Wrap filesystem operations (os.Stat, os.ReadDir, os.Lstat, filepath.EvalSymlinks) with context-aware timeouts to prevent the media scanner from hanging indefinitely on stale NFS/CIFS mounts. Introduce a directory cache (dirCache) for case-insensitive path lookups to reduce repeated filesystem calls during scanning. Also: - Handle SQLite UNIQUE constraint failures gracefully during indexing - Add phase constants (PhaseDiscovering, PhaseInitializing) replacing magic strings in status reporting - Switch GOPROXY from goproxy.io to direct - Fix test assertion for updated Total calculation formula
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
EvalSymlinks resolves all symlinks in the path including those in the temp directory itself (e.g. /var -> /private/var on macOS, 8.3 short names on Windows). Compare against the resolved expected path instead of the raw t.TempDir() path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.Stat,os.ReadDir,os.Lstat,filepath.EvalSymlinks) with context-aware 10s timeouts via a genericdoWithTimeout[T]helper, preventing the media scanner from hanging indefinitely on stale NFS/CIFS mountsdirCachefor case-insensitive path lookups duringFindPath, reducing repeated filesystem callsPhaseDiscovering/PhaseInitializingconstants for status reportinggoproxy.iotodirect