feat(mister): add FULLPATH-based game tracking for log_file_entry support#510
Closed
wizzomafizzo wants to merge 4 commits intomainfrom
Closed
feat(mister): add FULLPATH-based game tracking for log_file_entry support#510wizzomafizzo wants to merge 4 commits intomainfrom
wizzomafizzo wants to merge 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Add support for MiSTer's log_file_entry setting as an alternative method to track game launches. When log_file_entry=1 is enabled in mister.ini, MiSTer writes the launched game path to /tmp/STARTPATH. This provides a more direct and reliable tracking method compared to monitoring recents files. At startup, Zaparoo checks if STARTPATH exists. If present, it watches STARTPATH exclusively; otherwise, it falls back to the existing recents file monitoring.
STARTPATH contains the core/MRA path, not the ROM path. When log_file_entry=1 is enabled, watch FULLPATH instead which receives the actual game path when selected in the OSD browser. STARTPATH existence is still used as the signal that log_file_entry mode is active.
3692499 to
6e29dd3
Compare
Remove the STARTPATH-based detection of log_file_entry mode. Instead, always watch both the recents folder and FULLPATH file. Whichever source fires, the tracker handles it through the same SetActiveGame pipeline. This avoids the problem of STARTPATH not existing on fresh boot and removes the need to parse mister.ini.
Member
Author
|
absolute useless garbage feature this is. impossible to interpret the results, i feel sorry for anyone who uses it for their marquee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_file_entry=1is enabled inmister.ini, MiSTer writes game paths to/tmp/FULLPATHon OSD file selectionSetActiveGamepipeline — whichever fires, the tracker handles itlog_file_entrysetting