Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dirty but working POC for #297.
I think the API surface is due for some cleanup, so a major version bump would probably be best. Ideally the request serialization format should be pluggable (maybe even completely custom, provided by the user?) for maximum tree-shakability. Right now if I switch to MsgPack in Fable.Remoting.Client, Fable.SimpleJson, Parsimmon, etc. will still land in the bundle, even though MsgPack does not need any of them to serialize requests and deserialize responses.
I'll let the PR simmer for now.
note to self: DotnetClient with MsgPack serialization won't work on iOS