Enable ForwardRefs in dataclasses #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.14, type annotations are resolved in a delayed manner by default, and get resolved, on demand, when accession __annotations__. This allows writing recursive types such as a dataclass where some field contains itself. As a minor annoyance, accessing the type attribute of the fields, does not resolve the delayed forward reference. Add tests for Python 3.14
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
===========================================
- Coverage 100.00% 99.83% -0.17%
===========================================
Files 9 10 +1
Lines 608 620 +12
===========================================
+ Hits 608 619 +11
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.14, type annotations are resolved in a delayed manner by default, and get resolved, on demand, when accession annotations. This allows writing recursive types such as a dataclass where some field contains itself.
As a minor annoyance, accessing the type attribute of the fields, does not resolve the delayed forward reference.
Add tests for Python 3.14
Closes #13.