Add-GPLv3-metadata-and-DCO-docs#7
Merged
Merged
Conversation
Publish COPYING, CONTRIBUTING, and DCO files, set GPL-3.0-or-later in package metadata, add SPDX headers on entrypoints, document DCO sign-off with git commit -s, and add CI plus PR template checks. Signed-off-by: Zeid Diez <zeidalidiez@gmail.com>
Add trailing newlines, document .gitmessage setup in CONTRIBUTING.md, and pin CI action SHAs. Signed-off-by: Zeid Diez <zeidalidiez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up GPLv3 project metadata (without changing
LICENSE) and documents the DCO sign-off workflow so the DCO GitHub App can pass without admin bypass.Changes
COPYING— short GPL copyright noticeCONTRIBUTING.md— GPL contribution terms + DCO sign-off instructions (git commit -s,git rebase --signoff)DCO— Developer Certificate of Origin 1.1 text.gitmessage— commit template reminding contributors to sign offpackage.jsonlicense fields set toGPL-3.0-or-later.github/workflows/ci.yml— test, typecheck, build on PRs andmain.github/pull_request_template.md— license + DCO checkboxesReadme.md— expanded license sectionDCO note
The commit on this branch was created with
git commit -s, so DCO should pass here. For future work, usegit commit -son every commit.Testing
npm testnpm run typechecknpm run build:webGreptile Summary
[Linus Torvalds Mode] Look, I'm mildly shocked — someone actually READ the review comments and fixed the damn things. This PR adds GPLv3 project metadata (COPYING, DCO, CONTRIBUTING.md), applies
GPL-3.0-or-laterto all package.json files, drops SPDX headers on the entrypoints, wires up a CI workflow, and adds a PR template with license and DCO checkboxes.Key changes:
COPYING,DCO,CONTRIBUTING.md,.gitmessage— standard GPL/DCO scaffoldingpackage.jsonfiles now carry"license": "GPL-3.0-or-later"apps/web/src/main.tsx,apps/desktop/src/main.tsx,packages/core/src/index.ts,packages/ui/src/index.ts.github/workflows/ci.yml— single-job pipeline (test → typecheck → build:web) with SHA-pinned actions,permissions: contents: read, and concurrency cancellation.github/CODEOWNERS— assigns sole ownership to@zeidalidiezacross the whole repo.github/pull_request_template.md— enforces testing and DCO/license confirmationSigned-off-by:trailers, so DCO passesAll three findings from the prior review are addressed: trailing newlines at EOF are present,
.gitmessageactivation is documented inCONTRIBUTING.mdstep 2, and CI actions are now SHA-pinned with inline version comments. Barely competent, but it'll do.Confidence Score: 5/5
[Linus Torvalds Mode] Against all reasonable expectations, the author actually read the review and fixed all three flagged issues — SHA pinning, trailing newlines, and .gitmessage documentation. Both commits carry valid Signed-off-by trailers, the CI is lean and hardened, and no new issues were introduced. Safe to merge.
I was fully prepared to bury this thing, but there is nothing left to bury. Every prior P2 finding is resolved: actions are SHA-pinned with version comments, all six files have trailing newlines, and CONTRIBUTING.md now explicitly tells contributors to run
git config commit.template .gitmessage. The DCO text is verbatim 1.1, the SPDX headers are on the right files, and the CI workflow has minimal permissions and concurrency cancellation. No P0 or P1 findings. Score is 5 — not because this is impressive engineering, but because docs-and-config PRs that address all review feedback don't deserve anything less.No files need attention — shockingly, they're all in order. If you find something I missed, I'll be very surprised.
Important Files Changed
git config commit.template .gitmessagestep to activate the commit template; trailing newline present."license": "GPL-3.0-or-later"; no other changes.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Contributor forks repo] --> B[git config commit.template .gitmessage] B --> C[Makes changes] C --> D["git commit -s (DCO sign-off)"] D --> E[Opens PR against main] E --> F[PR template checklist\nnpm test / typecheck / build:web\nGPL-3.0-or-later agreement\nSigned-off-by on every commit] F --> G{DCO GitHub App} G -- All commits signed --> H[DCO pass] G -- Missing sign-off --> I[DCO fail\ngit rebase --signoff\ngit push --force-with-lease] I --> G H --> J{CI workflow} J --> K[actions/checkout SHA-pinned] K --> L[actions/setup-node SHA-pinned\nNode 20 / npm ci] L --> M[npm test] M --> N[npm run typecheck] N --> O[npm run build:web] O --> P{All green?} P -- Yes --> Q[CODEOWNERS review\n@zeidalidiez] P -- No --> R[Fix and repush] R --> J Q --> S[Merge to main]Reviews (2): Last reviewed commit: "Address Greptile review on PR 7" | Re-trigger Greptile