Install polyfill if clearImmediate is undefined#71
Open
robwalch wants to merge 1 commit intoYuzuJS:masterfrom
Open
Install polyfill if clearImmediate is undefined#71robwalch wants to merge 1 commit intoYuzuJS:masterfrom
robwalch wants to merge 1 commit intoYuzuJS:masterfrom
Conversation
Author
|
@domenic are you maintaining this project? If there's anything I can do to contribute towards getting a patch please let me know. Thanks! |
Author
|
On a side note, we'll be resolving the issue in our library by configuring webpack to not polyfill node modules (webpack |
Author
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At JW Player we've found sites that have
setImmediatepolyfilled withoutclearImmediate. This breaks our player's embed because it's compiled with webpack which depends on this module as a sub-dependency.Checking that both
setImmediateandclearImmediateare defined before exiting ensures that the polyfill is always attached when needed.