Closed
Conversation
Merge remote-tracking branch 'origin/main' into midi_handler_main
…it into a table, @Yolwoocle please consider doing the same thing for your generate_unknown_key_icon method
when "any" was pass, arg1-3 had nil value. made a dijuction in generate_midi_key_icon, if midi_type = "any", arg1-3 are asigned to ""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Midi as been added, tested, and made safe (I think).
If the lib doesn't charge, the game just keeps running, without midi support.