Skip to content

Prevent strip_tags() deprecation notices with add_submenu_page() #23003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonidasmi merged 8 commits into from
Mar 6, 2026
Merged

Prevent strip_tags() deprecation notices with add_submenu_page() #23003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b84286
Update `installation-success-integration.php`
sabernhardt Feb 17, 2026
2368ce8
Update `old-configuration-integration.php`
sabernhardt Feb 17, 2026
ec83509
Update `setup-url-interceptor.php`
sabernhardt Feb 17, 2026
785d16a
Update `settings-integration.php`
sabernhardt Feb 17, 2026
fa1c5dd
`Settings_Integration_Test`
sabernhardt Feb 17, 2026
20092cb
`Setup_Url_Interceptor_Add_Redirect_Page_Test`
sabernhardt Feb 17, 2026
f0d41bf
`Old_Configuration_Integration_Test`
sabernhardt Feb 17, 2026
4783a9f
`Installation_Success_Integration_Test`
sabernhardt Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dashboard/user-interface/setup/setup-url-interceptor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function register_hooks() {
*/
public function add_redirect_page( $pages ) {
\add_submenu_page(
'',
'options.php',
'',
'',
'wpseo_manage_options',
Expand Down
2 changes: 1 addition & 1 deletion src/integrations/admin/installation-success-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public function maybe_redirect() {
*/
public function add_submenu_page( $submenu_pages ) {
\add_submenu_page(
'',
'options.php',
\__( 'Installation Successful', 'wordpress-seo' ),
'',
'manage_options',
Expand Down
2 changes: 1 addition & 1 deletion src/integrations/admin/old-configuration-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function register_hooks() {
*/
public function add_submenu_page( $submenu_pages ) {
\add_submenu_page(
'',
'options.php',
\__( 'Old Configuration Wizard', 'wordpress-seo' ),
'',
'manage_options',
Expand Down
2 changes: 1 addition & 1 deletion src/integrations/settings-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ public function add_page( $pages ) {
public function add_settings_saved_page( $pages ) {
$runner = $this->runner;
\add_submenu_page(
'',
'options.php',
'',
'',
'wpseo_manage_options',
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Dashboard/User_Interface/Setup/Setup_Url_Interceptor_Add_Redirect_Page_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function test_add_redirect_page() {
Functions\expect( 'add_submenu_page' )
->once()
->with(
'',
'options.php',
'',
'',
'wpseo_manage_options',
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Integrations/Admin/Installation_Success_Integration_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ public function test_add_submenu_page() {

Monkey\Functions\expect( 'add_submenu_page' )
->with(
'',
'options.php',
'Installation Successful',
'',
'manage_options',
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Integrations/Admin/Old_Configuration_Integration_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function test_add_submenu_page() {

Monkey\Functions\expect( 'add_submenu_page' )
->with(
'',
'options.php',
'Old Configuration Wizard',
'',
'manage_options',
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Integrations/Settings_Integration_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public function test_get_conditionals() {
public function test_add_submenu_page() {

Monkey\Functions\expect( 'add_submenu_page' )
->with( '', '', '', 'wpseo_manage_options', 'wpseo_page_settings_saved', Mockery::type( 'Closure' ) );
->with( 'options.php', '', '', 'wpseo_manage_options', 'wpseo_page_settings_saved', Mockery::type( 'Closure' ) );

$submenu_pages = [
'array',
Expand Down
Loading