Skip to content

Fix cs#22992

Merged
pls78 merged 5 commits intofeature/schema_aggregatorfrom
fix-cs
Feb 16, 2026
Merged

Fix cs#22992
pls78 merged 5 commits intofeature/schema_aggregatorfrom
fix-cs

Conversation

@pls78
Copy link
Member

@pls78 pls78 commented Feb 16, 2026

Context

  • This PR Just fixes the CS errors induced by the update to YoastCS 3.3.0.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes various code style issues.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the feature, i guess...

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

@private-packagist
Copy link

private-packagist bot commented Feb 16, 2026

composer.lock

Dev Package changes

Package Operation From To About
brain/monkey upgrade 2.6.2 2.7.0 diff
dealerdirect/phpcodesniffer-composer-installer upgrade v1.0.0 v1.2.0 diff
phpcompatibility/phpcompatibility-paragonie upgrade 1.3.3 1.3.4 diff
phpcompatibility/phpcompatibility-wp upgrade 2.1.6 2.1.8 diff
phpcsstandards/phpcsextra upgrade 1.2.1 1.5.0 diff
phpcsstandards/phpcsutils upgrade 1.0.12 1.2.2 diff
phpstan/phpdoc-parser upgrade 1.33.0 2.3.2 diff
sirbrillig/phpcs-variable-analysis upgrade v2.12.0 v2.13.0 diff
slevomat/coding-standard upgrade 8.15.0 8.22.1 diff
squizlabs/php_codesniffer upgrade 3.12.0 3.13.5 diff
wp-coding-standards/wpcs upgrade 3.1.0 3.3.0 diff
yoast/wp-test-utils upgrade 1.2.0 1.2.1 diff
yoast/yoastcs upgrade 3.2.0 3.3.0 diff

Settings · Docs · Powered by Private Packagist

@github-actions
Copy link

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@pls78 pls78 changed the base branch from trunk to feature/schema_aggregator February 16, 2026 11:36
@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@pls78 pls78 added this to the feature/schema-aggregation milestone Feb 16, 2026
@pls78 pls78 added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed merge conflict labels Feb 16, 2026
@pls78 pls78 merged commit 4ca5515 into feature/schema_aggregator Feb 16, 2026
52 of 54 checks passed
@pls78 pls78 deleted the fix-cs branch February 16, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant