Skip to content

Add defensive coding for loading AI Generator when wpseoScriptData is not available#22976

Open
FAMarfuaty wants to merge 1 commit intotrunkfrom
2855-typeerror-cannot-read-properties-of-undefined-reading-geteditortype
Open

Add defensive coding for loading AI Generator when wpseoScriptData is not available#22976
FAMarfuaty wants to merge 1 commit intotrunkfrom
2855-typeerror-cannot-read-properties-of-undefined-reading-geteditortype

Conversation

@FAMarfuaty
Copy link
Contributor

@FAMarfuaty FAMarfuaty commented Feb 13, 2026

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a console error in the editor related to AI Generate feature that occurred when the “Enable SEO controls and assessments” option was disabled for a content type.

Relevant technical choices:

  • I recognize that this approach might not be optimal as the AI Generator JS asset is still loaded to the editor even when the feature is not available on that page when “Enable SEO controls and assessments” option was disabled. I couldn't find an easy way to prevent loading this script in that case.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Test together with this accompanying PR in Premium: https://github.com/Yoast/wordpress-seo-premium/pull/4889
  • Install and activate Yoast SEO and Yoast SEO Premium
  • Go to Yoast setting for a content type, for example for Posts: Yoast SEO > Settings > Content types > Posts
  • Toggle off "Enable SEO controls and assessments"
  • Create a post
  • Confirm that you don't see the following errors in the console:
Screenshot 2026-02-13 at 16 19 12
  • Toggle on "Enable SEO controls and assessments" for Posts
  • Smoke test AI Generator and AI Optimize features and confirm that they still works as expected
  • Also test with different content types such as Pages, taxonomies and CPTs

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2855

@FAMarfuaty FAMarfuaty added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Feb 13, 2026
@FAMarfuaty FAMarfuaty marked this pull request as ready for review February 13, 2026 15:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7f0339dba3bbd202f9199b35fd63deaba954bf4c

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.478%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/initialize.js 0 1 0.0%
Totals Coverage Status
Change from base Build eb924f46bdd305d26586562bb0cf5755ff700ac1: 0.5%
Covered Lines: 33068
Relevant Lines: 62015

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants