upstream pull#4
Draft
ivomink wants to merge 3598 commits into
Draft
Conversation
## Short description Ports the other half of the closed Wizden [#41611](space-wizards/space-station-14#41611). Nuking the station now triggers end of round, regardless of gamemode. Also adds a non-round ending Nuke, if Admins want to mess with it. ## Why we need to add this To go with [#4299](#4299), and also for Lone Ops. ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld, alexalexmax - add: Added a nuke that doesn't end the round to the spawn menu. - tweak: The (normal) nuke going off now starts the end of round sequence, regardless of gamemode. --------- Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description <!-- What do you propose to change with your PR? --> Fix an issue with the dragon health scaling caused by a failing station retrieval function ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> It's already added, just wasn't working. No idea how long. To jog the memory a bit, this essentially makes the dragon 50% tankier at most on highpop. Apparently the dragon is real weak these days so seems like a good thing to get working again. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Trosling - fix: Fixed health scaling for ghost role dragons.
## Short description This adds a flexible achievement framework that can be extended through prototypes and server-side progress hooks, while also giving players visible feedback and persistent unlocks through NullLink. ## Why we need to add this https://discord.com/channels/1272545509562777621/1492837273685852230 A surge of dopamine ## Media (Video/Screenshots) <img width="575" height="231" alt="image" src="https://github.com/user-attachments/assets/d7bf5d95-ec4b-453e-b102-558f01105d44" /> <img width="1063" height="758" alt="image" src="https://github.com/user-attachments/assets/b84f0dfd-9d62-4ec5-b2d8-24fb089ff9f0" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: CringeCursed - add: Added Achievements system. --------- Co-authored-by: Rinary <rinary.super@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
## Short description Fix the secuirty cyborg issues ## Why we need to add this Previously. putting a positronic brain into the borg would let it drop all items. furthermore it would drop all items anways when critted and get the ability to drop/pickup the only item that should be droppable is the contraband bag. ## Media (Video/Screenshots) NA ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Scarlet Lightweaver - tweak: Split the security cyborg module up a bit, the contrabag module is its own thing now. - fix: Fixed security borgs being able to drop and pickup items when crit/PB being inserted. --------- Co-authored-by: R3v3l4t1on <237806892+R3v3l4t1on@users.noreply.github.com> Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description Fixes sorting of chemicals / drinks / reagents in the guidebook to once again be alphabetical. ## Why we need to add this Fixes a regression in #3989 which caused guidebook reagents to be listed in inverse order. Cause of this is that the `FrameUpdate` performance optimization iterates through the reagent list in inverse order, meaning the output became inverted of the input. https://github.com/ss14Starlight/space-station-14/blob/b190c6e9e00e0d6bbdc2e193b901bcd3c933ce84/Content.Client/Guidebook/Controls/GuideReagentGroupEmbed.xaml.cs#L76-L82 The simplest solution which does not touch the optimization above is to pre-sort in inverse order instead, which results in the correct final order. ## Media (Video/Screenshots) <img width="500" alt="image" src="https://github.com/user-attachments/assets/6ab621a6-85a9-4ecd-a23d-f8cd2a1d2a87" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Xale - fix: Fixed guidebook sorting of chemicals and drinks to once again be in alphabetical order.
## Short description This PR aims to replace the "Walkie" preset on radios for "Radio" preset. ## Why we need to add this I can only imagine that this is a mistake, by no means is radio a walkie, the current preset in my opinion sounds bad, making the noise behind every message, and such. ## Media (Video/Screenshots) ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Fasuh - fix: Fixed radio using a wrong TTS effect.
## Short description <!-- What do you propose to change with your PR? --> Rock anomalies no longer cause weather inside of stations. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Currently, rock anomalies spawn FloorAsteroidTile, which is a sandy steel tile that is not immune to weather. Crew can crowbar and replace it with steel tile, but it really shouldn't be causing weather in the first place. Replacing with the weather-proof variant of the tile. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="1388" height="844" alt="image" src="https://github.com/user-attachments/assets/3ba11841-d84b-4493-bb4e-c2cd74e9e021" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Ohelig - fix: Rock anomalies no longer cause weather inside the station.
## Short description Fixes the human observation console and adds some missing edge connector overrides. ## Why we need to add this its been visually broken for ages. the tech disk terminal, television. and arcades where causing computers to connect visually. ## Media (Video/Screenshots) <img width="431" height="459" alt="image" src="https://github.com/user-attachments/assets/4db7656f-f638-438a-8780-124cd7c6cd80" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. :cl: STARLIGHT TEAM - fix: Human observation console looks as it should.
## Short description <!-- What do you propose to change with your PR? --> Adds 35 new achievements to the game. Icons by @wayiscool and @Trosling <3 ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> With the new achievement system we need actual achievements for players to hunt for. Adds the following non-hidden achievements: | Name | Description | | --- | --- | | Dragon Slayer | Deal the final blow to a dragon. | | Whiskey Echo Whiskey | Roll traitor for the first time. | | Assuming Direct Control | Emag a borg. | | Homing Meteors | Get hit by a meteor. | | Should Have Braced | Get hit by an immovable rod. | | Stranded | Fail to make it back to the salvage shuttle in time during an expedition. | | How to Charge? | Try to hit someone with an uncharged stun baton as a member of security. | | Guard Dog | Finish a round as BSO without a single command staff member dying. | | Bad Dog | Finish a round as BSO after every command staff member dies at least once. | | Special Circumstances | Be a crew member in a round where war is declared. | | Lone Operative | Succeed as a Lone Operative on a round with 50 or more players. | | One Against All | Succeed as a Lone Operative on a round with 100 or more players. | | One Man Syndicate | Succeed as a Lone Operative on a round with 150 or more players. | | John Syndicate | Succeed as a Lone Operative on a round with 200 or more players. | | Liver Failure | Metabolize 250 units of ethanol in a single shift. | | Paradox Undone | Kill your paradox clone. | | He's dead, Jim. | Have at least 2000 total damage and at least some damage in every standard damage group. | | Syndie-Cat | Greentext as a syndicate agent after buying Cat Ears from your uplink. | | John Connor | Kill a terminator. | | Finish the Fight | Disarm a nuclear device before it detonates. | | Theory of Everything | As Research Director, oversee the completion of all available research. | | You Super, Matter | As the CE or an Atmos Tech, be on station when the supermatter reaches zero durability. | | Forbidden Candy | Get vaporized by touching the supermatter. | | Took an Arrow to the Knee | Get hit by an arrow. | | That Frezon Stare | Metabolize Frezon. | | Sus | Kill a crew member within 30 seconds of exiting a vent. | | A weapon to surpass... you know... | Construct a Durand. | | Rodentia Rex | As a Rat King, have at least 30 rat servants. | | The Robust Salvagers | As a salvager, kill a nuclear operative. | Also adds 6 hidden achievements not listed here. Many achievements do not have unique icons yet, these will be added as they are finished in future PRs in the interest of getting achievements out for players faster. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Dragon Slayer: <img width="64" height="64" alt="dragonSlayer" src="https://github.com/user-attachments/assets/afeadbef-2721-4314-9ced-cb5302cb7f9f" /> Theory of Everything: <img width="64" height="64" alt="theoryOfEverything" src="https://github.com/user-attachments/assets/e7a39993-551c-4961-ae36-49b1851b303e" /> First Spawn: <img width="64" height="64" alt="fishMedal" src="https://github.com/user-attachments/assets/084f70ab-6ab2-4119-8446-7194b397badc" /> Contributor: <img width="64" height="64" alt="contributorMedal" src="https://github.com/user-attachments/assets/0755bb62-d5cf-422e-930e-cb4152091592" /> Assuming Direct Control: <img width="64" height="64" alt="assumingDirectControl" src="https://github.com/user-attachments/assets/fad4ce44-a818-4744-be3d-aa22925b1bcb" /> Whiskey Echo Whiskey: <img width="64" height="64" alt="whiskeyEcho" src="https://github.com/user-attachments/assets/6ef45bb8-a613-49c8-9291-82010e066220" /> Homing Meteors: <img width="64" height="64" alt="homingMeteors" src="https://github.com/user-attachments/assets/bd68b1a4-4b2c-443f-900c-91c699d47c93" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: FeralCreature - add: 29 achievements. Happy hunting! - add: 6 hidden achievements. These ones hunt you. --------- Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description <!-- What do you propose to change with your PR? --> Refines and refactors most of lets say not good code in vampire systems. ## Why we need to add this ## Media (Video/Screenshots) ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Adds bunch of pools for harvester ## Why we need to add this ## Media (Video/Screenshots) ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: CringeCursed - add: Added 6 new Bluespace Harvester reward pools. --------- Co-authored-by: Rinary <rinary.super@gmail.com>
<!-- IT'S NOT WIZDENS REPO, IF YOU WANT TO ADD YOUR CHANGES ON ALL SERVERS, CREATE PR TO WIZDENS REPO --> ## Short description <!-- What do you propose to change with your PR? --> - Adds terror spiders into gamerule pool. - Adds terror spiders end mechanism. - Adds ability to wrap humanoids into web. - Changed lay eggs action, now it works only on wrapped humanoids. - Fixes bug when died spiderling can evolve into normal spider. - Changed attack animations with None visuals, now they move from user to attack target instead of spawn on attack target, also changes opacity while moving closer to target. - Changed lunge animation to be more smooth and more steps, now you can see how a player takes a swing. - Changed slash attack animation to be more smooth. - Added kick back animation when someone attacked humanoid(s). - Changed thermal vision shader to half alpha version(less toxic) for terror spiders. - Adds ammonia generator building for terror spiders so now they can recover atmosphere. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Antag waits in WIP state already 2 years. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ### Animations change https://github.com/user-attachments/assets/631c5c14-d746-4f71-b81f-c6bbdc01d60a ### Half alpha shader <img width="889" height="770" alt="image" src="https://github.com/user-attachments/assets/ffdd3fe4-78cf-41f0-84b2-249f93ee09bf" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: STARLIGHT TEAM - add: WE WANT TO ANNOUNCE TERROR ON OUR SECTOR!(Terror spiders). - fix: Fixed bug when spiderling grow up into spider even if it died. - add: Added wrap action for spiders, now they can wrap humanoids(this prevents rot process). - tweak: Changed lay eggs ability, now it works only on wrapped humanoids. - tweak: Changed regular attack animations(punch, bite...) to be more smooth and fancy. - tweak: Changed lunge animation(swing animation on attack) to be more smooth and fancy. - tweak: Changed slash attack animation to be more smooth.(Idk how to make it more fancy, effect bad itself). - add: Added kick back animation for humanoids when they're attacked. - tweak: Changed thermal vision shader alpha from 1.0f to 0.5f for terror spiders thermal vision. - add: Added ammonia generator building for terror spiders. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
## Short description <!-- What do you propose to change with your PR? --> Limit non-humanoid antag selection to require hands. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> A short while ago I made a change to allow nonhumanoids to become antags, since the pipeline indicates we may have more playable nonhumanoids. Unfortunately, Hamlet became a SELF agent. He... doesn't have the ability to manipulate tools. We should probably gate the ability for non-humanoids to become antags behind things like tool manipulation, as a lot of antag work requires the ability to use hands. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Tested via running starlight-dev with traitor/traitor reinforcement settings on, then ghostroling hamlet. After six minutes, I became a traitor. Made my changes, ran the same test again. After 15 minutes the traitor gamerule established itself and Hamlet was not a traitor. I then restarted the round, ran the same test but as a smart corgi. After about six minutes, I became a traitor. ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Sparlight - tweak: Non-humanoid antag selection is now gated behind having hands - sorry Hamlet players. <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. -->
## Short description <!-- What do you propose to change with your PR? --> Adds the ability to mute channels on your headset via the interaction menu It works by shifting channels from the Encryption Keys' channel list, to a "MutedChannel" list. This MutedChannel list is not checked by the radio system, and as such it becomes effectively disabled until switched back into the "Channels" list by the user. It _might_ need colour coding, but I am not sure that Verbs support this, as the text is literally just a string. Correct me if I'm wrong in that regard. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Particularly on HighPop, it would be very nice to be able to mute Common. As Captain especially, you rarely need all the channel _on_ all the time, you just need the _option_ to be able to use them. Realistically, nobody would put up with 150 people talking their ear off anyhow. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> [channelmutedemonstration.webm](https://github.com/user-attachments/assets/de2f246d-34ec-412c-9c01-324e26f6c355) ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Trosling - add: Added the ability to mute radio channels on your headset. --------- Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description <!-- What do you propose to change with your PR? --> Should fix null links bans issue. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Bugfix ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Rinary - fix: Maybe, fixed issue with bans sync. Now it should work properly.
## Short description Fixes rounds being unable to start. ## Checks - [ ] I do not require assistance to complete the PR. - [ ] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [ ] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: STARLIGHT TEAM - fix: Fixes rounds being unable to start.
## Short description <!-- What do you propose to change with your PR? --> Fixes some bugs with critting anomalies. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Bugfixes ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="497" height="551" alt="image" src="https://github.com/user-attachments/assets/23c3efaf-a100-4948-aa52-70e1206ae786" /> <img width="470" height="518" alt="image" src="https://github.com/user-attachments/assets/4d42254c-bf3a-4024-a3b0-2ead3b4a013a" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: CrazyPhantom - fix: Fixed some bugs with Anomalies, they should no longer lag everyone or fail to gib you on crit. Co-authored-by: Your Name <you@example.com>
## Short description <!-- What do you propose to change with your PR? --> This should Fix the JobTest fail on every PR, this is how it was changed upstream, I would just Cherry-Pick upstream but theres other big changes in it that require more PR's ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Test fail fix ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. Not player facing --------- Co-authored-by: Your Name <you@example.com>
## Short description <!-- What do you propose to change with your PR? --> Adds a few more borgi names; implements the smart corgi name dataset that's been unused since implementation; and grants the 'mistake' corgis from borgi creation ghost roles. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Smart corgis generally only really occur in the sandbox as a result of the random nature of borgi creation via biocubes. Despite the allegations of being smart corgis, they displayed no signs of intelligence over their peers. This is because they had no players piloting them. These will now be ghost roles upon creation. Smart corgis have long just been named 'smart corgi (###)'. Since they're meant to be played by players, they will likely want a name that isn't a generic identifier. As such, I've implemented the existing corgi names table and expanded upon it a little. As a slight adjustment, I've moved them to avariant that does not speak Galactic Common as a clear and discernible tradeoff from borgis. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="1409" height="936" alt="image" src="https://github.com/user-attachments/assets/2091ba2f-4022-4bb7-a99d-04dd10af0095" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Sparlight - add: There are now about twice as many random name options for both borgis and syndicate borgis. - tweak: Smart corgis made as a result of borgi creation have a chance of being a ghost role. - fix: Smart corgis made as a result of borgi creation now have random names. <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. -->
## Short description changes as the result of the first playtests - fixes the bug where it was impossible to strip a devil - adds a temporary stopgap to people mispelling damnation names: on edit finish, will show a popup alerting everyone of misspellings if any exist (when i have time in 4 weeks Ill make a permanent solution along with the rest of the devil changes, think like a slight highlight if the damnation is valid, etc) - devil cant fire guns anymore - devil gets a jaunt ability, was recommended by staff and multiple players after the first 2 playtests as a way to both manoeuvre and maintain aura - this has 2 charges, one for entering a room, and one for exiting once a deal is complete, and each charge takes 2.5 min to restore - Infernal jaunt unlocks at 5 souls, when you start to become more obvious/apparent - encourages stealth/backstreet deals while you are less obvious, and then as you more obviously become a devil you get escape powers to match - reduce terminator damnation value, because there are like 10 terminators every devil admeme - hopefully disincentivising it a bit more will make it less common ## Media (Video/Screenshots) <img width="729" height="579" alt="Screenshot_20260519_141111" src="https://github.com/user-attachments/assets/6fa68402-23ac-4c12-a725-7f32dbf33c9f" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Arkanic - fix: Fix being unable to strip the devil. - add: After 5 souls captured devil gains a 2-charge jaunt ability with a 5 min recharge, for entering and then exiting a room with aura. - add: Show a popup when there is misspellings in the names of a contract, so you will know beforehand if you are about to be accidentally short-changed (temporary, will be reworked to be better in future). - tweak: Devil can't fire guns anymore (you shouldnt be anyway lo). - tweak: Reduced value of terminator damnation to hopefully make it slightly less common.
## Short description <!-- What do you propose to change with your PR? --> Cleans up Pipe and Cabledocking to milk every ounce of performance they got. They had missmatches between the systems that should be almost identical and were often polling every entity. Unfortunately the diff is very messed up cause file scoped namespace. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Performance up! ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> N/A ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: CrazyPhantom - tweak: Pipe and Cabledocks are now even more performant. Hopefully less/no more delays in pipes and cables anchoring. --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description <!-- What do you propose to change with your PR? --> Reverts #4487 and adds an Assert in JobWeightTest so job prototypes are resolved before the round starts and adds a cleanup so client dosen't break test ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Test Fail Fix Attempt ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. Not player facing --------- Co-authored-by: Your Name <you@example.com>
## Short description Winter Coats and Boots now give Cold armor. ## Why we need to add this No armor against this, and they're literally winter wear. Lets us experiment with cold damage in the future, too. ## Media (Video/Screenshots) <img width="286" height="168" alt="image" src="https://github.com/user-attachments/assets/8cefabe3-84fb-4d4f-b02c-2859eef30bee" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld - tweak: Winter Coats and Winter Boots now provide Cold Armor. I mean, that's literally what they're for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
LICENSE: BSD-2-Clause
Why we need to add this
Media (Video/Screenshots)
Checks
Changelog
🆑