Skip to content

Provide command-line interface#109

Closed
qsantos wants to merge 2 commits into
Yelp:masterfrom
qsantos:master
Closed

Provide command-line interface#109
qsantos wants to merge 2 commits into
Yelp:masterfrom
qsantos:master

Conversation

@qsantos
Copy link
Copy Markdown

@qsantos qsantos commented Nov 29, 2018

Makes the following possible:

python -m swagger_spec_validator "http://petstore.swagger.io/v2/swagger.json"

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 29, 2018

Coverage Status

Coverage decreased (-2.9%) to 95.522% when pulling ebceb95 on qsantos:master into 2a99f42 on Yelp:master.

Copy link
Copy Markdown
Contributor

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please also check the output of the travis run and fix the issues pre-commit mentioned. You can run make install-hooks to make sure those hooks will be run when you commit code.

Comment thread requirements-dev.txt Outdated
pytest
jsonschema
pyyaml
six
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requirements are already listed in setup.py, no need to add them here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, the correct way is to put a line with a single . so that pip install -r requirements-dev.txt will automatically look in setup.py as well. I've pushed a new version reflecting this.

@qsantos qsantos force-pushed the master branch 2 times, most recently from f22cae4 to 0b1cf49 Compare December 3, 2018 17:45
This makes it possible to call the script as follows:

python -m swagger_spec_validator "http://petstore.swagger.io/v2/swagger.json"
@nicktimko
Copy link
Copy Markdown

nicktimko commented May 17, 2019

See #105 which includes some basic tests, an entrypoint, documentation, and processing of the raised exception to print the message rather than dumping a traceback.

@qsantos qsantos closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants