Migration to Yarnspinner 2.5.0#275
Draft
Galdormin wants to merge 6 commits intoYarnSpinnerTool:mainfrom
Draft
Conversation
- YarnSpinner.Compiler/Declaration.cs - YarnSpinner.Compiler/DeclarationVisitor.cs - YarnSpinner.Compiler/StringTableManager.cs - YarnSpinner.Compiler/Utility.cs
- validate_unique_inferred_variable seems to break the tests and was removed in the 3.0
- YarnSpinner.Tests/ErrorHandlingTests.cs - YarnSpinner.Tests/ProjectTests.cs - YarnSpinner.Tests/TagTests.cs
Contributor
Author
|
@janhohenheim I need help here. In here, they used 2 fields to store callbacks. I don't think I can do that using a closure in rust, especially because they need a mutable reference of the dialogue. I had considered storing all the set variables and allowing a TestPlan function to be called by providing an FnOnce closure. That should work, but I’m not sure if you have any better ideas? |
Collaborator
|
I'll check when the jam is over in 2 days :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there are a lot of changes and I'm not familiar with the non-bevy crates, I'll start the migration to the last v2 supported version.
Git diff: YarnSpinnerTool/YarnSpinner@da39c71...v2.5.0
I've looked at the git diff, and this is the files with changes (except doc changes) among the Compiler and Runtime. LanguageServer and tests were ignored.
Compiler
Runtime
Test
YarnSpinner.Tests/TypeTests.cs=> test for validate_unique_inferred_variable (removed in 3.0)