Skip to content

Reject empty session title slugs #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w287346141 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Open

Reject empty session title slugs #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/session-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,13 @@ export function makeSessionNameFromTitle(
): string | null {
const normalized = normalizeGeneratedSessionTitle(title);
if (!normalized) return null;
const base = sanitizeName(
normalized
.replace(/[\s_]+/g, "-")
.replace(/[^\w\-\u4e00-\u9fa5]+/g, "-")
.replace(/-+/g, "-")
.replace(/^-|-$/g, ""),
);
if (!base) return null;
const slug = normalized
.replace(/[\s_]+/g, "-")
.replace(/[^\w\-\u4e00-\u9fa5]+/g, "-")
.replace(/-+/g, "-")
.replace(/^-|-$/g, "");
if (!slug) return null;
const base = sanitizeName(slug);
const current = opts.currentName ? sanitizeName(opts.currentName) : "";
const exists = opts.exists ?? ((name: string) => existsSync(sessionPath(name)));
if (base === current || !exists(base)) return base;
Expand Down
5 changes: 5 additions & 0 deletions tests/session-title.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ describe("session title generation", () => {
).toBe("修复-会话-损坏");
});

it("rejects titles that do not contain usable slug text", () => {
expect(makeSessionNameFromTitle("___", { exists: () => false })).toBeNull();
expect(makeSessionNameFromTitle("---", { exists: () => false })).toBeNull();
});

it("only auto-names default first-turn sessions that have not been named before", () => {
expect(shouldAutoNameSession("default-20260517123456", {}, 1)).toBe(true);
expect(shouldAutoNameSession("default-20260517123456", {}, 2)).toBe(false);
Expand Down
Loading