Fixes a number of compilation errors that occur when the "full" feature set is enabled#4
Open
logankoester wants to merge 10 commits intoYASSERRMD:mainfrom
Open
Fixes a number of compilation errors that occur when the "full" feature set is enabled#4logankoester wants to merge 10 commits intoYASSERRMD:mainfrom
logankoester wants to merge 10 commits intoYASSERRMD:mainfrom
Conversation
Extracts scheme from URL and includes it in host string formation Previously only hostname was extracted, causing potential connection issues when non-HTTP schemes were specified in the URL configuration Host now properly formatted as "scheme://hostname" instead of just hostname
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of compile-time errors occur when the "full" feature set is enabled.
This change resolves each of these errors, allowing the examples to run as expected (eg:
cargo run --example ollama_local --features full) and the test suite to pass (cargo test --features full).Changes:
GenerateEmbeddingsRequest::new()constructor patternf32) andFormatType::JsonvariantResponseFormat::JsonObjectenum variant instead of unsupported struct initialization and changes message content from string references to owned stringswhere_clausesvariables)DeletePointsBuilderpattern instead of manualPointsSelectorconstruction (which fails to compile due to incompatibility with the qdrant-client crate)