Simple thread safety fix + a more reliable way to check if managed#2
Open
kylemacfarlane wants to merge 3 commits intoXof:masterfrom
kylemacfarlane:master
Open
Simple thread safety fix + a more reliable way to check if managed#2kylemacfarlane wants to merge 3 commits intoXof:masterfrom kylemacfarlane:master
kylemacfarlane wants to merge 3 commits intoXof:masterfrom
kylemacfarlane:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes two fixes.
The current SID is now thread local.
More sensible behaviour if for some reason autocommit is off but this decorator is in use.
When I use this decorator I also remove the custom
_leave_transaction_management. Django itself sometimes starts transactions within the ORM and this fix does not cover those occasions. Placing a fix in this decorator gives people false hope when they really need to just patch Django proper.