fix/ReplantEnchantment/SeedUsage #359
Conversation
Signed-off-by: Illyrius <FitimQ@live.nl>
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR simplifies the ReplantEnchantment implementation by removing redundant code and a TODO comment about seed usage.
Changes:
- Removed redundant block type reassignment that had no functional effect
- Simplified the Runnable lambda to a single line
- Removed TODO comment about seed consumption without implementing the referenced functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| instance.server.scheduler.runTaskLater( | ||
| instance, | ||
| Runnable { | ||
| val blockType = block.type | ||
|
|
||
| block.type = blockType | ||
| block.blockData = ageable.apply { age = 0 } | ||
| }, | ||
| Runnable { block.blockData = ageable.apply { age = 0 } }, | ||
| 2, | ||
| ) |
There was a problem hiding this comment.
The TODO comment about seed consumption has been removed without implementing the seed consumption functionality. The current implementation replants crops without consuming any seeds from drops or player inventory. If this is intentional game design (free replanting as the enchantment's benefit), the decision should be documented. If seeds should be consumed when replanting, consider implementing logic to remove one seed from the block drops or player inventory.
Description
How Has This Been Tested?