Skip to content

containers/docker: nuke the old docker containers #19164#1932

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:nuke-old-containers
Jan 16, 2026
Merged

containers/docker: nuke the old docker containers #19164#1932
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:nuke-old-containers

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Jan 8, 2026

Proposed changes

Ref: ethereum#19164

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 8, 2026 05:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes four obsolete Docker container definitions that were building go-ethereum (not XDC) from extremely outdated dependencies. The removed Dockerfiles were using deprecated Ubuntu Xenial and Alpine 3.7 base images with Go 1.9, and were building go-ethereum release 1.8 from the Ethereum repository rather than XDC network code.

  • Removed all four outdated Dockerfile definitions (master/develop variants for Ubuntu/Alpine)
  • No references to these files exist in the current codebase, CI/CD pipelines, or documentation
  • Cleanup aligns with issue ethereum#19164 to remove old docker containers

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
containers/docker/master-ubuntu/Dockerfile Removed outdated Ubuntu-based Dockerfile building go-ethereum 1.8 with Go 1.9
containers/docker/master-alpine/Dockerfile Removed outdated Alpine-based Dockerfile building go-ethereum 1.8
containers/docker/develop-ubuntu/Dockerfile Removed outdated Ubuntu-based development Dockerfile building go-ethereum
containers/docker/develop-alpine/Dockerfile Removed outdated Alpine-based development Dockerfile building go-ethereum

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AnilChinchawale AnilChinchawale merged commit bc9bd0c into XinFinOrg:dev-upgrade Jan 16, 2026
19 checks passed
@gzliudan gzliudan deleted the nuke-old-containers branch January 16, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants