containers/docker: nuke the old docker containers #19164#1932
containers/docker: nuke the old docker containers #19164#1932AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes four obsolete Docker container definitions that were building go-ethereum (not XDC) from extremely outdated dependencies. The removed Dockerfiles were using deprecated Ubuntu Xenial and Alpine 3.7 base images with Go 1.9, and were building go-ethereum release 1.8 from the Ethereum repository rather than XDC network code.
- Removed all four outdated Dockerfile definitions (master/develop variants for Ubuntu/Alpine)
- No references to these files exist in the current codebase, CI/CD pipelines, or documentation
- Cleanup aligns with issue ethereum#19164 to remove old docker containers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| containers/docker/master-ubuntu/Dockerfile | Removed outdated Ubuntu-based Dockerfile building go-ethereum 1.8 with Go 1.9 |
| containers/docker/master-alpine/Dockerfile | Removed outdated Alpine-based Dockerfile building go-ethereum 1.8 |
| containers/docker/develop-ubuntu/Dockerfile | Removed outdated Ubuntu-based development Dockerfile building go-ethereum |
| containers/docker/develop-alpine/Dockerfile | Removed outdated Alpine-based development Dockerfile building go-ethereum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
Ref: ethereum#19164
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that