core/txpool/legacypool: narrow down the scope of the variable #27471

[gzliudan]

Proposed changes

Ref: ethereum#27471

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request refactors the transaction pool architecture to support a modular design with multiple specialized subpools. The main changes include:

• Restructuring the monolithic txpool package into a coordinator (core/txpool) and implementation subpackage (core/txpool/legacypool)
• Introducing a SubPool interface to enable different transaction pool implementations
• Updating type signatures from types.Transactions to []*types.Transaction for consistency
• Adding new event subscription utilities (JoinSubscriptions) for managing multiple subscription sources

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/txpool/txpool.go	New coordinator pool that aggregates multiple subpools
core/txpool/subpool.go	Interface definition for transaction subpool implementations
core/txpool/legacypool/legacypool.go	Refactored legacy pool implementation moved to subpackage
core/txpool/errors.go	Centralized error definitions for txpool
miner/worker.go	Updated transaction handling and binary encoding logic
core/types/transaction.go	Fixed special transaction separation logic
event/multisub.go	New utility for joining multiple subscriptions
eth/backend.go	Updated to use new pool initialization pattern
Multiple test files	Updated to use new legacypool package and APIs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.