core/txpool/legacypool: handle missing head in reset #27479

[gzliudan]

Proposed changes

Ref: ethereum#27479

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the transaction pool architecture to introduce a modular design with a coordinator-subpool pattern, and adds handling for missing head blocks in the reset logic. The changes originate from upstream go-ethereum improvements.

Key Changes:

• Refactored transaction pool into a coordinator (core/txpool) and legacy subpool (core/txpool/legacypool)
• Added missing head block handling in vote verification
• Changed transaction type aliases from types.Transactions to explicit []*types.Transaction
• Updated API methods to use wrapped txpool.Transaction type
• Added new event subscription helper (JoinSubscriptions)

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/txpool/txpool.go	New coordinator implementation managing subpools
core/txpool/subpool.go	SubPool interface defining the contract for transaction subpools
core/txpool/legacypool/legacypool.go	Refactored legacy pool as a SubPool implementation
core/txpool/errors.go	Centralized error definitions
event/multisub.go	New helper for joining multiple subscriptions
consensus/XDPoS/engines/engine_v2/vote.go	Added missing head block handling
miner/worker.go	Updated transaction handling and data extraction logic
eth/backend.go	Updated to use new txpool architecture
Multiple test files	Updated to match new API signatures

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.